Support multiple license sources#4527
Draft
oheger-bosch wants to merge 2 commits intoeclipse-apoapsis:mainfrom
Draft
Support multiple license sources#4527oheger-bosch wants to merge 2 commits intoeclipse-apoapsis:mainfrom
oheger-bosch wants to merge 2 commits intoeclipse-apoapsis:mainfrom
Conversation
This is a follow-up for [1]. It extends the API model to handle multiple license sources for a rule violation which is now supported by ORT. Add a new property `licenseSources` to avoid breaking clients that can still use the old `licenseSource` property. [1]: eclipse-apoapsis#4181 Signed-off-by: Oliver Heger <oliver.heger@bosch.com>
Display all license sources for rule violations that are now returned by the API. Fixes eclipse-apoapsis#4185. Signed-off-by: Oliver Heger <oliver.heger@bosch.com>
|
Issues referenced in commit messages and issues linked to this PR are not in sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a solution for #4185: To support multiple license sources in rule violations in the API and the UI. It uses the approach to introduce a new
licenseSourcesproperty in the data model, keeping the old one to not break the API and older clients.In the UI, the license sources are displayed as comma-delimited list. If you want a more sophisticated design, I am out:
