Add Apache Kafka Event Interface For Repositories #523
Conversation
|
Hi @geso02, thank you very much for your PR and the nice addition to BaSyx. Can you please check the AAS Environment. There is a test that seems to be failing. |
- Corrected automatic upload of files by ensuring paths are annotated with @value, so the correct files are uploaded as expected. - Removed the `basyx.environment` property from tests, as it is unrelated to the test scope and streamlines the configuration.
|
I found some incorrect configurations in the upload within the AASEnvironment. The pathsToLoad used during bean creation was missing the @value annotation in all places. I've now added it. In the authorization test case, we then encountered an issue because basyx.environment was now being referenced, but this test was not concerned with it and did not provide mocks for it, causing it to fail. I've now pushed the changes again and will check if there are issues in other areas as well. |
This commit resolves an issue where a Submodel, which should only be used in submodel-repository tests, was mistakenly registered in environment-related tests. The Submodel is now conditionally provided via profiles, ensuring it is only available in the appropriate tests and no longer causes failures in the environment tests.
|
I’ve fixed the issue with the build by adjusting the registration of a Submodel that was intended for submodel-related tests but was mistakenly included in environment tests due to test dependencies. I’ve now ensured that the Submodel is only registered in the submodel tests using profiles, and it’s no longer active in the environment tests, which resolves the issue and allows the build to pass again. |
geso02
changed the title
basyx environment is not assigned in auth preloader otherwise
geso02
changed the title
|
Hi @geso02, sorry for not finding the time to review this yet. This is a very big PR and I am missing the relevant background knowledge for Kafka to do the review. Would it be possible to schedule a meeting so that you can give me a walkthrough of your PR? In the meantime, could you please have a look at the merge conflict that occurred because of the recent changes that happened? |
yes we can have a meeting in teams, for example Friday afternoon
I can look at it again Friday morning |
group could already be handled by another listener
- Add default topic names for Kafka setup - Update and improve README files for better clarity and structure - Adjust tests and code to resolve merge conflicts - Fix failing test case that was breaking the CI process
There was a problem hiding this comment.
Please remove this unrelated change
2 participants
Closes #522
Description:
This pull request introduces an Apache Kafka event interface, enhancing message processing reliability and scalability, and making the system more suitable for larger and more demanding environments.
Key Features
Thank you for reviewing this addition!