Add feature hierarchical registry for AAS and Submodel Registries #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronzi
reviewed
Jan 29, 2025
.../eclipse/digitaltwin/basyx/aasregistry/feature/hierarchy/HierarchicalAasRegistryStorage.java
Show resolved
Hide resolved
aaronzi
reviewed
Jan 29, 2025
...igitaltwin/basyx/submodelregistry/feature/hierarchy/HierarchicalSubmodelRegistryStorage.java
Show resolved
Hide resolved
aaronzi
reviewed
Jan 29, 2025
Comment on lines
80
to
89
| @Test | ||
| public void getAllSubmodelDescriptor_InRoot() throws ApiException { | ||
| GetSubmodelDescriptorsResult actualDescriptors = getRootRegistryApi().getAllSubmodelDescriptors(1, null); | ||
|
|
||
| SubmodelDescriptor expectedDescriptor = getDescriptorFactory().getRootOnlySmDescriptor(); | ||
|
|
||
| List<SubmodelDescriptor> expectedDescriptors = Arrays.asList(expectedDescriptor); | ||
|
|
||
| assertEquals(expectedDescriptors, actualDescriptors.getResult()); | ||
| } |
Member
There was a problem hiding this comment.
This test seems to be unrelated since the feature is not used for getAll.
aaronzi
requested changes
Jan 29, 2025
Member
aaronzi
left a comment
aaronzi
left a comment
There was a problem hiding this comment.
Thank you for the PR. Please have a look at the headers again. The year should be updated to 2025
aaronzi
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #551