-
Notifications
You must be signed in to change notification settings - Fork 64
Refactor Backend Architecture for the remaining Repositories, AASXFileServer and AasDiscoveryService #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aaronzi
merged 43 commits into
eclipse-basyx:main
from
mateusmolina-iese:feat/refactor-other-repos-arch
Feb 25, 2025
Merged
Refactor Backend Architecture for the remaining Repositories, AASXFileServer and AasDiscoveryService #612
aaronzi
merged 43 commits into
eclipse-basyx:main
from
mateusmolina-iese:feat/refactor-other-repos-arch
Feb 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-sdk into feat/refactor-other-repos-arch
…udAasDiscoveryFactory
…rver-sdk into feat/refactor-other-repos-arch
…delRepositoryFactory
…te with repository backends
…ce factories to use it
99142cf to
04e6f5d
Compare
# Conflicts: # basyx.submodelrepository/basyx.submodelrepository-backend/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/backend/CrudSubmodelRepository.java
aa8cd46 to
3008c3a
Compare
…ServiceFactory for operations
3008c3a to
44a0da6
Compare
f39636a to
d5df214
Compare
… of smrepo/service
# Conflicts: # basyx.aasrepository/basyx.aasrepository-feature-mqtt/src/test/java/org/eclipse/digitaltwin/basyx/aasrepository/feature/mqtt/TestMqttV2AASAggregatorObserver.java # basyx.submodelrepository/basyx.submodelrepository-feature-mqtt/src/test/java/org/eclipse/digitaltwin/basyx/submodelrepository/feature/mqtt/TestMqttSubmodelObserver.java # basyx.submodelservice/basyx.submodelservice-feature-mqtt/src/test/java/org/eclipse/digitaltwin/basyx/submodelrepository/feature/mqtt/TestMqttSubmodelObserver.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to the 1st Phase of #584
This PR refactors the backend architecture for the Submodel, AAS, ConceptDescription repositories/services, the AASXFileServer, and the AasDiscoveryService to (1) rely on existing CrudRepository implementations when available -- for example, MongoDB -- and (2) use backend-specific implementation for the services.
Following a similar implementation strategy of #570, with the following changes:
Other than that, this PR brings several other changes:
Suggestions for future work: