Skip to content

Conversation

@geso02
Copy link
Contributor

@geso02 geso02 commented Feb 6, 2025

See issue: #614

@aaronzi
Copy link
Member

aaronzi commented Feb 6, 2025

Hi @geso02,

Thank you for your PR.
Please have a look at the remarks on this PR: #484
The fix involves a few more steps/changes.

Since the other PR is almost ready, I would suggest you have a look at it and see if that PR already fixes the problem you are trying to fix in yours. If yes I can try to finalize the PR so that the fix is deployed as fast as possible.

@geso02
Copy link
Contributor Author

geso02 commented Feb 6, 2025

My implementation returns the passed element without using a result from the repository service. I think this is sufficient, as the data storage does not change the object. This would be useful if, for example, an ID is generated from an SQL database via a sequence. We do not have this case in our implementation and so the solution here would be the simplest. But you can also use the other solution, as we are using the locally built image with the bug fix for now.

@aaronzi
Copy link
Member

aaronzi commented Feb 17, 2025

Superseded by #484

@aaronzi aaronzi closed this Feb 17, 2025
@geso02 geso02 deleted the 614-bugfix-post-submodelelement branch May 6, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants