Skip to content

make legacy attenuate private (lack of symbols mgmt) #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Korbik merged 1 commit into from
Apr 14, 2025
Merged

make legacy attenuate private (lack of symbols mgmt) #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/biscuitsec/biscuit/token/UnverifiedBiscuit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ public UnverifiedBiscuit attenuate(
* @param block new block (should be generated from a Block builder)
* @return
*/
public UnverifiedBiscuit attenuate(final SecureRandom rng, final KeyPair keypair, Block block)
private UnverifiedBiscuit attenuate(final SecureRandom rng, final KeyPair keypair, Block block)
throws Error {
UnverifiedBiscuit copiedBiscuit = this.copy();

Expand Down
8 changes: 3 additions & 5 deletions src/test/java/org/biscuitsec/biscuit/token/UnverifiedBiscuitTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import static org.junit.jupiter.api.Assertions.assertEquals;

import biscuit.format.schema.Schema;
import biscuit.format.schema.Schema.PublicKey.Algorithm;
import java.security.InvalidKeyException;
import java.security.NoSuchAlgorithmException;
import java.security.SecureRandom;
Expand Down Expand Up @@ -56,7 +57,6 @@ public void testBasic()
// SECOND BLOCK
System.out.println("preparing the second block");

KeyPair keypair1 = KeyPair.generate(Schema.PublicKey.Algorithm.Ed25519, rng);
org.biscuitsec.biscuit.token.builder.Block block1 = deser0.createBlock();
block1.addCheck(
Utils.check(
Expand All @@ -67,7 +67,7 @@ public void testBasic()
Utils.pred("resource", List.of(Utils.var("resource"))),
Utils.pred("operation", List.of(Utils.str("read"))),
Utils.pred("right", List.of(Utils.var("resource"), Utils.str("read")))))));
UnverifiedBiscuit unverifiedBiscuit1 = deser0.attenuate(rng, keypair1, block1.build());
UnverifiedBiscuit unverifiedBiscuit1 = deser0.attenuate(block1, Algorithm.Ed25519);

System.out.println(unverifiedBiscuit1.print());

Expand All @@ -87,8 +87,6 @@ public void testBasic()
// THIRD BLOCK
System.out.println("preparing the third block");

KeyPair keypair2 = KeyPair.generate(Schema.PublicKey.Algorithm.Ed25519, rng);

Block block2 = unverifiedBiscuit1.createBlock();
block2.addCheck(
Utils.check(
Expand All @@ -97,7 +95,7 @@ public void testBasic()
List.of(Utils.str("file1")),
List.of(Utils.pred("resource", List.of(Utils.str("file1")))))));

UnverifiedBiscuit unverifiedBiscuit2 = unverifiedBiscuit1.attenuate(rng, keypair2, block2);
UnverifiedBiscuit unverifiedBiscuit2 = unverifiedBiscuit1.attenuate(block2, Algorithm.Ed25519);

System.out.println(unverifiedBiscuit2.print());

Expand Down