Skip to content

Do not recreate the bouncycastle provider every time #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Korbik merged 1 commit into from
Jul 13, 2025
Merged

Do not recreate the bouncycastle provider every time #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/org/eclipse/biscuit/crypto/SECP256R1KeyPair.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ final class SECP256R1KeyPair extends KeyPair {
}

static Signature getSignature() throws NoSuchAlgorithmException {
return Signature.getInstance("SHA256withECDSA", new BouncyCastleProvider());
return Signature.getInstance(
"SHA256withECDSA", Security.getProvider(BouncyCastleProvider.PROVIDER_NAME));
}

@Override
Expand Down
7 changes: 0 additions & 7 deletions src/test/java/org/eclipse/biscuit/crypto/SignatureTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,15 @@
import java.security.InvalidKeyException;
import java.security.NoSuchAlgorithmException;
import java.security.SecureRandom;
import java.security.Security;
import java.security.SignatureException;
import org.eclipse.biscuit.error.Error;
import org.eclipse.biscuit.token.Biscuit;
import org.bouncycastle.jce.provider.BouncyCastleProvider;
import org.junit.jupiter.api.Test;

/**
* @serial exclude
*/
public class SignatureTest {

static {
Security.addProvider(new BouncyCastleProvider());
}

@Test
public void testSerialize() {
prTestSerialize(Schema.PublicKey.Algorithm.Ed25519, 32);
Expand Down