Reduce/change 3rd party dependencies #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Wow, a big one, but very nice. Thanks! |
Korbik
requested changes
Aug 13, 2025
Contributor
Korbik
left a comment
Korbik
left a comment
There was a problem hiding this comment.
Good work. Some suggestions
preuss-adam
force-pushed
the
apreuss/reduce-dependencies
branch
from
875f3b5 to
b0dd7dc
Compare
Contributor
Author
|
@Korbik thanks for review. changes are pushed. |
preuss-adam
force-pushed
the
apreuss/reduce-dependencies
branch
from
b0dd7dc to
9340b20
Compare
Korbik
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is best reviewed commit-by-commit. At a high level, it comprises of two major changes:
gsonlibrary with the more modern and maintainedjackson.vavrdependency, replacing with builtins and custom types where necessary.