-
Notifications
You must be signed in to change notification settings - Fork 13
feat: add support to use rcodesign for macosx signing service #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
staging service is deployed and a Jenkins job is running: https://ci.eclipse.org/cbi/job/webservices-monitoring/job/macos-signing-staging/ |
|
rcodesign 0.28.0 has been released including the necessary fix: https://github.com/indygreg/apple-platform-rs/releases/tag/apple-codesign%2F0.28.0 the fix is not mentioned in the release notes but I checked the files at the release commit and the change is present, will update the PR and test. Its in the changelog of the sub-crate where it was fixed: https://github.com/indygreg/apple-platform-rs/blob/main/apple-xar/CHANGELOG.md#0190 |
|
updated the staging service to use the latest version of rcodesign. Will ask projects to use the staging service for testing. |
|
@netomi, it's too bad this repo is gone, it seems we won't be able to build on top of it as easily. |
|
omg |
|
that was by accident, will restore |
|
Thank you! |
|
I cannot reopen, it seems that the link to the original repo is lost. Will use #642 from there. Thanks! |
This fixes #380 and #461.
The implementation itself is finished and working in local testing, however the deployment needs to be finalized.
On top of that signing needs to be checked with various file types and deep signing needs to be verified as well.
The used rcodesign version (latest release) has a bug handling pkg files, created a PR for the project to fix that.