Publish through GitHub actions#380
Conversation
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
jonahgraham
left a comment
There was a problem hiding this comment.
Wonderful. Thanks @jreineckearm
As for having a changelog in here I am ok with that. FWIW at one point I thought the best solution was to combine cdt-gdb-adapter and cdt-gdb-vscode into a single git repo, but I don't know how to do that.
As for "next" - we haven't used it in a while, so we could also just drop it to make life simpler. Which would mean a release process is running yarn version once and pushing the change + the tag.
Could make sense to make a test publish with current next version after merge.
IIUC You need to add more options to the yarn publish for this to work. Specifically you need --tag next. I think you can just publish a new version of the adapter that has no other changes. If you get added to the cdt-gdb-adapter npmjs permissions you can also run npm unpublish cdt-gdb-adapter@<version> if you accidentally publish something broken.
Let's add a CHANGELOG then during one of the next releases.
OK. That would spare one step.
I would hope it just picks the current version in package.json ( |
|
I'll merge once the |
* Windows paths with spaces in Makefile * publish workflow (ported from vscode-ui-components) * publish config * cancel in progress actions on new push Signed-off-by: Jens Reinecke <jens.reinecke@arm.com> --------- Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Partly addresses #379
Notes:
nextversion after merge.Updates push-workflow to publish release to NPM if
mainif desired (needs a bit more logic).The publish job creates a new clone of the repo.
Intended publish process is:
nextversion. This is not automated.Does not include from #379
nextversion in package.json.On top of this