Setting a warning for enable/disable breakpoint commands#385
Merged
jreineckearm merged 10 commits intoeclipse-cdt-cloud:mainfrom Jun 5, 2025
Merged
Setting a warning for enable/disable breakpoint commands#385jreineckearm merged 10 commits intoeclipse-cdt-cloud:mainfrom
jreineckearm merged 10 commits intoeclipse-cdt-cloud:mainfrom
Conversation
…le bp commands as they cannot be reflected in the GUI
Contributor
|
Note: bug fix related to #360 |
jreineckearm
requested changes
Jun 4, 2025
Contributor
jreineckearm
left a comment
There was a problem hiding this comment.
Please review the regular expressions. They unfortunately have side effects.
Might also be an opportunity to refine the error message.
jreineckearm
approved these changes
Jun 5, 2025
Contributor
jreineckearm
left a comment
There was a problem hiding this comment.
Thanks! Changes LGTM, tests have been added.
omarArm
added a commit
to omarArm/cdt-gdb-adapter
that referenced
this pull request
Jun 13, 2025
…-cloud#385) * removing unneeded custom bp event, setting a warning for enable/disable bp commands as they cannot be reflected in the GUI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately enable/disable bp commands supported by GDB cannot be reflected in the GUI using the normal Breakpoint event.
For now, a warning message will be printed in the debug console to the user whenever these commands are being used