Skip to content

Setting a warning for enable/disable breakpoint commands#385

Merged
jreineckearm merged 10 commits intoeclipse-cdt-cloud:mainfrom
omarArm:bpIssueFix
Jun 5, 2025
Merged

Setting a warning for enable/disable breakpoint commands#385
jreineckearm merged 10 commits intoeclipse-cdt-cloud:mainfrom
omarArm:bpIssueFix

Conversation

@omarArm
Copy link
Contributor

@omarArm omarArm commented Jun 4, 2025

Unfortunately enable/disable bp commands supported by GDB cannot be reflected in the GUI using the normal Breakpoint event.

For now, a warning message will be printed in the debug console to the user whenever these commands are being used

@jreineckearm
Copy link
Contributor

Note: bug fix related to #360

Copy link
Contributor

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the regular expressions. They unfortunately have side effects.
Might also be an opportunity to refine the error message.

Copy link
Contributor

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changes LGTM, tests have been added.

@jreineckearm jreineckearm merged commit 4c3ef96 into eclipse-cdt-cloud:main Jun 5, 2025
4 checks passed
omarArm added a commit to omarArm/cdt-gdb-adapter that referenced this pull request Jun 13, 2025
…-cloud#385)

* removing unneeded custom bp event, setting a warning for enable/disable bp commands as they cannot be reflected in the GUI
@omarArm omarArm deleted the bpIssueFix branch July 15, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants