v2.0.0 preparations #137
Merged
v2.0.0 preparations #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extension renaming Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
jreineckearm
force-pushed
the
release-preparations
branch
from
fd56215 to
5b0d117
Compare
jonahgraham
approved these changes
Jan 20, 2025
Contributor
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
- The extension will show now with a different name in Open VSX. And after installation in VS Code.
+1 to update the name to this
- This could be a reason for a major version change, i.e. to v2.0.0. But I believe removal of the Memory Browser would be the next major version update due to removal of a feature. Maybe not an issue at all to have two major version increments in short time (if the removal happens soon).
I think you should jump to 2.0, we can have a 3.0 soon after too. But I don't feel strongly that the changes so far necessitate the change from 1.1 -> 2.0
Contributor
Author
In this case, I believe we also should remove the note at the top of the README.MD. Doesn't feel right to talk about a preliminary milestone release anymore when bumping major versions. |
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
Contributor
Author
|
Should anything else change on this PR before we can get serious with making a release? |
jonahgraham
approved these changes
Jan 22, 2025
Contributor
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
I renew my approval.
Contributor
Author
|
Thanks! @thegecko , would you mind merging this PR and then push a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #136 (see issue for rational why not updating more dependencies first).
Should be merged after #135.
Note that this contains some potentially controversial changes concerning the extension's name.
Preparations for first release to both VS Code marketplace and Open VSX registry.
v1.1.0v2.0.0.CHANGELOG.mdandpackage.json.displayNamewhich is shown on the marketplace and presumably Open VSX instead ofcdt-gdb-vscode.displayNameto "CDT GDB Debug Adapter Extension"descriptionto "CDT GDB debug adapter extension for Visual Studio Code" to better agree with VS Code brand guidelines.README.md,DEVELOPMENT.md, andCONTRIBUTING.mdtitles (in the files) accordingly.Adding
displayNameand changing description and MD title names (in the files) is the potentially controversial part:[Update]: Changed to prepare for v2.0.0, no longer v1.1.0.
@jonahgraham , @thegecko , opinions on this would be much appreciated.