Skip to content

docs: add documentation of updateThreadInfo setting#197

Merged
jreineckearm merged 1 commit intoeclipse-cdt-cloud:mainfrom
andy9a9:docs/thread_info
Jan 20, 2026
Merged

docs: add documentation of updateThreadInfo setting#197
jreineckearm merged 1 commit intoeclipse-cdt-cloud:mainfrom
andy9a9:docs/thread_info

Conversation

@andy9a9
Copy link
Contributor

@andy9a9 andy9a9 commented Jan 15, 2026

Document new setting from eclipse-cdt-cloud/cdt-gdb-adapter#482

Copy link
Contributor

@cwalther cwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the starting point!

@cwalther cwalther requested a review from jreineckearm January 16, 2026 09:40
Copy link
Contributor

@cwalther cwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks. Any comments from @jreineckearm before we merge?

Nitpick (not a blocker): Now that the list is outside of the table, you could use Markdown syntax for it again instead of HTML.

By the way, my comments were meant as discussion inputs, not as orders, but if you agree with them that’s fine too.

Copy link
Contributor

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs updates! LGTM in general.

I agree with @cwalther that we should avoid HTML in markdown files if possible. In this case, - for bullet items and backticks instead of <code>. But not necessarily a blocker to get this done.

Good to merge unless you'd like to make any last changes, @andy9a9 .

@andy9a9
Copy link
Contributor Author

andy9a9 commented Jan 20, 2026

Fine with me, but if I have to change it, no problem, but let me know.

@jreineckearm
Copy link
Contributor

OK, will merge then.

@jreineckearm jreineckearm merged commit e6bc2ac into eclipse-cdt-cloud:main Jan 20, 2026
5 checks passed
@andy9a9 andy9a9 deleted the docs/thread_info branch January 20, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants