-
Notifications
You must be signed in to change notification settings - Fork 60
Implement autoExpandLevel for EntryModel trees #1202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement autoExpandLevel for EntryModel trees #1202
Conversation
5891711 to
151a424
Compare
|
Fixes #801 |
bhufmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tsp-typescript-client 0.7.0 has been deployed. Please update the package.json file for traceviewer-base and traceviewer-react-components to this version.
I tested this change with trace server that with applied this setting. It works well:
eclipse-tracecompass/org.eclipse.tracecompass#289
|
I updated Seems to work fine: |
151a424 to
92c004b
Compare
|
Add support for the autoExpandLevel flag to automatically collapse tree nodes beyond the specified depth level. When autoExpandLevel is set, nodes at depths greater than the specified level are automatically collapsed in the tree view. Related to eclipse-cdt-cloud/tsp-typescript-client#130 Signed-off-by: Will Yang <[email protected]>
92c004b to
182a865
Compare
|
Fixed the linting errors (hopefully) |
|
IP Ticket to open:
ATM, when I run |
|
A review is required for npm/npmjs/-/allure-commandline/2.34.0. Note: |
|
@williamsyang-work Update: seems you already are on the latest baseline - not sure why |
|
All good for the license check. |
marcdumais-work
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @williamsyang-work !
I quickly tried the new feature in the vscode extension, using yarn link, and it worked well too:
bhufmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for adding this.


What it does
Add support for the autoExpandLevel flag to automatically collapse tree nodes beyond the specified depth level. When autoExpandLevel is set, nodes at depths greater than the specified level are automatically collapsed in the tree view.
Related to eclipse-cdt-cloud/tsp-typescript-client#130
How to test
What I did was comment out
getCollapsedNodesFromAutoExpandLeveland add a replacement test call using different values forautoExpandLevelto ensure that it was working correctly for each value.Follow-ups
No follow ups required.
Review checklist