Fix timegraph misalignment when entry label is blank#1209
Merged
PatrickTasse merged 1 commit intoeclipse-cdt-cloud:masterfrom Jul 2, 2025
Merged
Fix timegraph misalignment when entry label is blank#1209PatrickTasse merged 1 commit intoeclipse-cdt-cloud:masterfrom
PatrickTasse merged 1 commit intoeclipse-cdt-cloud:masterfrom
Conversation
Set the height for timegraph td in .css stylesheet since the line-height for timegraph tr does not apply if there is no text. Fixes eclipse-cdt-cloud#1208 Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
bhufmann
approved these changes
Jul 2, 2025
Contributor
bhufmann
left a comment
bhufmann
left a comment
There was a problem hiding this comment.
It fixes the referenced bug. Thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Set the height for timegraph td in .css stylesheet since the line-height for timegraph tr does not apply if there is no text.
Fixes #1208
How to test
Open kernel trace and Resources status view. Check that separator rows between CPUs have same height in tree and timegraph.
Follow-ups
Consider supporting variable height rows. See issue #133.
Review checklist