Add global range selection sync to Gantt chart with toggle button#1221
Draft
aaanh wants to merge 5 commits intoeclipse-cdt-cloud:masterfrom
Draft
Add global range selection sync to Gantt chart with toggle button#1221aaanh wants to merge 5 commits intoeclipse-cdt-cloud:masterfrom
aaanh wants to merge 5 commits intoeclipse-cdt-cloud:masterfrom
Conversation
0f5bfbd to
106959e
Compare
Contributor
|
I think the license check CI failure is unrelated to the content of the PR and can be ignored for now. |
106959e to
9388306
Compare
ae433fe to
71563ac
Compare
Contributor
Author
|
Latest changes to the PR:
|
71563ac to
4f9cf0e
Compare
Signed-off-by: Anh Hoang Nguyen <anh.nguyen@ericsson.com>
Signed-off-by: Anh Hoang Nguyen <anh.nguyen@ericsson.com>
8b736c2 to
ab28cc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Add range selection sync feature, similar to Flame graph selection, to the extension. Along with a sync toggle button for the Gantt chart.
flame.graph.selection.mp4
Along with this PR, refactored the
UnitControllerclass'snumberTranslatorto use a new utility factory methodcreateNumberTranslator.How to test
Follow-ups
N/A
Review checklist