[CI][workflows] Use node 20, 22 in workflows #309
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add node 20,22 for build and tests (keep 18 for now). Use 20 for publish and license check. Signed-off-by: Marc Dumais <[email protected]>
Contributor
|
@marcdumais-work there is a license check failure. Do you have a issue tracker open for that? |
Contributor
Author
I will, thanks. I decided to go with another branch name, so I open a new PR and do it then. |
Contributor
Author
|
Closing in favor of #310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Prepare for node.js 18 EoL and our transition to using node 20 as default.
How to test
Confirm CI still passes.
Follow-ups
Review checklist