Skip to content

Generate openapi.yaml for Gantt Chart, update README and license/copyright #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bhufmann merged 3 commits into from
Jul 18, 2025
Merged

Generate openapi.yaml for Gantt Chart, update README and license/copyright #127

bhufmann merged 3 commits into from
Jul 18, 2025

Conversation

@aaanh
Copy link
Contributor

@aaanh aaanh commented Jul 10, 2025 •
edited
Loading

What it does

Added GANTT_CHART to DataProvider.ProviderType and regenerated the openapi.yaml with that.

Related to changes made in the incubator: eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator#209

How to test

Follow-ups

Review checklist

  • As an author, I have thoroughly tested my changes and carefully followed the instructions in this template

@aaanh aaanh force-pushed the aaanh/regen-yaml branch from c40c07a to 52a3927 Compare July 10, 2025 20:17
bhufmann
bhufmann requested changes Jul 10, 2025
View reviewed changes
bhufmann
bhufmann requested changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clean up the commits. There should be only on commit for the GANTT_CHART change (Make sure that the version is 0.5.0 in both yaml files). Then one commit for the README updates, and one for license year. I think that's it.

It looks good otherwise.

@aaanh
Copy link
Contributor Author

aaanh commented Jul 14, 2025 •
edited
Loading

Could you please clean up the commits. There should be only on commit for the GANTT_CHART change (Make sure that the version is 0.5.0 in both yaml files). Then one commit for the README updates, and one for license year. I think that's it.

It looks good otherwise.

Okay! I'll squash the changes and split the README and openapi.licens.

@aaanh aaanh force-pushed the aaanh/regen-yaml branch from f7e234f to 6c25d59 Compare July 14, 2025 14:58
bhufmann
bhufmann approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@aaanh aaanh changed the title Generated openapi.yaml and update licensing/copyright info Generated openapi.yaml for Gantt Chart and update licensing/copyright info Jul 15, 2025
@aaanh aaanh changed the title Generated openapi.yaml for Gantt Chart and update licensing/copyright info Generate openapi.yaml for Gantt Chart, update README and license/copyright Jul 15, 2025
@aaanh aaanh mentioned this pull request Jul 16, 2025
Merged
7 tasks
@bhufmann bhufmann requested a review from MatthewKhouzam July 16, 2025 19:46
MatthewKhouzam
MatthewKhouzam approved these changes Jul 18, 2025
View reviewed changes
Copy link

@MatthewKhouzam MatthewKhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks Anh!

@bhufmann bhufmann merged commit 16c5c0a into eclipse-cdt-cloud:master Jul 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhufmann bhufmann bhufmann approved these changes

@MatthewKhouzam MatthewKhouzam MatthewKhouzam approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aaanh @bhufmann @MatthewKhouzam