Add optional OutputCapabilities to the output descriptor #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickTasse
requested changes
Jan 21, 2025
| /** | ||
| * Whether the data provider can create derived data providers. | ||
| */ | ||
| canCreate: boolean; |
Contributor
There was a problem hiding this comment.
Both should be optional with '?' ?
OutputCapabilities indicate capabilities of am output, such as "canCreate" and "canDelete". "canCreate" indicates that a given output can create a derived outputs. "canDelete" indicates that a given output can be deleted. Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
force-pushed
the
dp-capilities
branch
from
9543937 to
0c2f9ab
Compare
PatrickTasse
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
OutputCapabilities indicate capabilities of an output, such as "canCreate" and "canDelete". "canCreate" indicates that a given output can create a derived outputs. "canDelete" indicates that a given output can be deleted.
See also ADR: eclipse-cdt-cloud/theia-trace-extension#1158
How to test
Run the unit tests (
yarn tests)Follow-ups
N/A
Review checklist
Signed-off-by: Bernd Hufmann [email protected]