Support ErrorResponse for error cases in all specified messages #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcdumais-work
previously approved these changes
Jul 17, 2025
Contributor
marcdumais-work
left a comment
marcdumais-work
left a comment
There was a problem hiding this comment.
LGTM - thanks for this improvement!
note: I tested using the trace server from this PR:
eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator#208
bhufmann
force-pushed
the
errorResponse
branch
2 times, most recently
from
3ed2a4f to
8c06fdb
Compare
Return optional ErrorResponse in new method getErrorResponse() of TspClientResponse. Contributes to fix issue: eclipse-cdt-cloud/trace-server-protocol#122 Signed-off-by: Bernd Hufmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Return the ErrorResponse message in the getStatusMessage() of TspClientResponse.
Contributes to fix issue:
eclipse-cdt-cloud/trace-server-protocol#122
How to test
Code review and use it in a FE (e.g. vscode-trace-extension) and try an example error case, e.g. open trace with file that is not a trace.
Follow-ups
N/A
Review checklist