Skip to content

Conversation

@aaanh
Copy link
Contributor

@aaanh aaanh commented Jul 10, 2025

What it does

Simply add an enum value for GANTT_CHART. Should be merged first before theia-trace-extension is updated.

How to test

Should be tested with the PR. eclipse-cdt-cloud/theia-trace-extension#1205

Follow-ups

N/A

Review checklist

  • As an author, I have thoroughly tested my changes and carefully followed the instructions in this template

Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have only one commit with proper commit message for the gantt chart addition.

@aaanh aaanh force-pushed the aaanh/gantt-provider-type branch from 2b0c785 to 55f2eca Compare July 15, 2025 17:21
bhufmann
bhufmann previously approved these changes Jul 15, 2025
Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@bhufmann bhufmann requested a review from MatthewKhouzam July 15, 2025 19:27
@bhufmann bhufmann merged commit 46afa19 into eclipse-cdt-cloud:master Jul 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants