Introduce GenericXY endpoint #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siwei-zhang-work
force-pushed
the
generic-xy
branch
2 times, most recently
from
5a7ed7c to
cb2858b
Compare
siwei-zhang-work
changed the title
siwei-zhang-work
force-pushed
the
generic-xy
branch
3 times, most recently
from
ee8e276 to
dc2d8f7
Compare
siwei-zhang-work
changed the title
siwei-zhang-work
force-pushed
the
generic-xy
branch
from
dc2d8f7 to
41e6b6d
Compare
siwei-zhang-work
force-pushed
the
generic-xy
branch
from
41e6b6d to
1db1164
Compare
Introduce generic xy endpoint to support non-time x-axis for XY view. Signed-off-by: Siwei Zhang <[email protected]>
siwei-zhang-work
force-pushed
the
generic-xy
branch
from
1db1164 to
18f5338
Compare
Contributor
|
The license check failure is unrelated to this PR's content and can be ignored for now. |
siwei-zhang-work
changed the title
bhufmann
approved these changes
Sep 8, 2025
Contributor
bhufmann
left a comment
bhufmann
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
PatrickTasse
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Introduce GenericXY endpoint to support non-time x-axis for XY view.
The endpoint is specified in:
eclipse-cdt-cloud/trace-server-protocol#114
How to test
Unit tests are added in this commit.
Follow-ups
Updates to vscode-trace-extension to implement the new view.
Review checklist