Skip to content

Conversation

@jreineckearm
Copy link
Contributor

@jreineckearm jreineckearm commented Mar 21, 2025

What it does

  • Updates to node version 20.x.
  • Updated some dependencies (vsce and node types).

Fixes CI after environment updates to default GitHub runners.

How to test

Review checklist

Reminder for reviewers

Signed-off-by: Jens Reinecke <[email protected]>
Copy link

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Running yarn audit, there are quite a few vulnerabilities, though mostly in our development dependencies. Is there interest in a broader dependency uplift to try to address some of those?

@jreineckearm
Copy link
Contributor Author

Thanks for raising this, @colin-grant-work . Yes, I believe we need to do some housekeeping. I'll raise a separate issue as this may require a bit more testing.

I am keen to make a release by the end of the month to get updates from the last year out to the public. There is one docs PR and one release preps PR ongoing after which the time may be right. So, may only make that dependency update after the release to minimize risk of catching hidden last minute regressions.

@jreineckearm jreineckearm merged commit 455a5eb into eclipse-cdt-cloud:main Mar 21, 2025
5 checks passed
@jreineckearm jreineckearm deleted the dependency-updates branch March 21, 2025 14:35
@jreineckearm
Copy link
Contributor Author

For completeness: raised #162 as a follow-up to sort outdated dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants