JUnit5 Draft work (do not push as is) #1390
Draft
+8,340
−3,246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't needed as JDT automatically injects what it needs when running tests.
…nit5 SemanticTestBase is the base class for a huge hierarchy of tests and all those test updates are included in this commit.
BaseTestFramework is the base class for a hierarchy of tests and all those test updates are included in this commit.
BaseTestFramework is the base class for a hierarchy of tests and all those test updates are included in this commit.
…se to JUnit5 PreprocessorTestsBase is the base class for a hierarchy of tests and all those test updates are included in this commit.
…to JUnit5 DOMFileBasePluginTest is the base class for a hierarchy of tests and all those test updates are included in this commit.
Many of the parser tests are in complicated hierarchies, this is the commit to convert the rest of them.
IndexTestBase is the base class for a hierarchy of tests and all those test updates are included in this commit. Bug246129 needed to be renamed to Bug246129Test to ensure it is detected by default Maven Surefire test discovery
…Unit5 FileBasePluginTestCase is the base class for a hierarchy of tests and all those test updates are included in this commit.
…o JUnit5 CompletionTestBase is the base class for a hierarchy of tests and all those test updates are included in this commit.
…TestCase to JUnit5 OneSourceMultipleHeadersTestCase is the base class for a hierarchy of tests and all those test updates are included in this commit.
The suite source folder is mostly utility functions. This change includes moving most of it to JUnit5. Only BaseTestCase and BaseTestCase5 still have references to JUnit < 5 Includes deleting unreferenced test class with no tests in it
The mode source folder is mostly non-hierarchy tests and are included here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my WIP so far on #1379. This can't be pushed as is, but if someone want to keep working on JUnit5 conversions of org.eclipse.cdt.core tests, this is a good starting point. Some of this has already been merged to main.