Improved MSVC detection fixes #929 #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgraham
added
the
build
Member
|
@azuo This PR got neglected as there seems to be none of the active committers in Eclipse CDT that know about this issue. I think this is probably correct based on the vswhere documentation about finding a VC installation here https://github.com/microsoft/vswhere/wiki/Find-VC#batch This may be eligible under #1347 - but I think it needs at least some manual testing first since there are no automated tests in this area. cc: @MarkZ3 as the author of detectVSInstallation in case he still knows about this and can comment. |
Contributor
|
I tested it with my VS2022 environment and it works. So it's fine by me to merge. Thanks! |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.