fix: workspace source comparison

[olexii4]

What does this PR do?

This PR fixes the issue where workspace creation from samples always created new workspaces, ignoring the "Create new" checkbox. The fix ensures factory attributes (revision, editor, storageType, etc.) are included in source comparison.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Fixes https://issues.redhat.com/browse/CRW-9659

Is it tested? How?

1. Deploy DS with the image from this PR.
2. Go to User Dashboard and ensure "Create New" check box is turned on by default.
3. Create a new workspace from Java Lombok sample.
4. Turn off "Create New" check box.
5. Try to create a new workspace from Java Lombok sample.

Release Notes

Docs PR

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[che-bot]

Click here to review and test in web IDE:

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1422

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1422", name: che-dashboard}]}}]"

[codecov]

Codecov Report

❌ Patch coverage is 98.01325% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.59%. Comparing base (721cecf) to head (55efc12).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...ontend/src/store/Workspaces/Preferences/helpers.ts	90.32%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #1422    +/-   ##
========================================
  Coverage   92.59%   92.59%            
========================================
  Files         519      520     +1     
  Lines       48700    48819   +119     
  Branches     3604     3621    +17     
========================================
+ Hits        45092    45206   +114     
- Misses       3570     3575     +5     
  Partials       38       38            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1422

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1422", name: che-dashboard}]}}]"

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1422

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1422", name: che-dashboard}]}}]"

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1422

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1422", name: che-dashboard}]}}]"

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1422

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1422", name: che-dashboard}]}}]"

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1422

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1422", name: che-dashboard}]}}]"

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1422

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1422", name: che-dashboard}]}}]"

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1422

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1422", name: che-dashboard}]}}]"

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1422

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1422", name: che-dashboard}]}}]"

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1422

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1422", name: che-dashboard}]}}]"

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1422

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1422", name: che-dashboard}]}}]"

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1422

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1422", name: che-dashboard}]}}]"

[vinokurig]

Works as expected according to the provided description. Import via SSH url with branch works as expected.

[svor]

LGTM

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1422

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1422", name: che-dashboard}]}}]"

[artaleks9]

/retest

[artaleks9]

Verified on Eclipse Che deployed on OCP v4.20 with quay.io/eclipse/che-dashboard:pr-1422

• run workspaces from Dashboard samples (used che-code/insiders due to Che-code editor failed to start in containers with OPENSSL version < 3.4.0 che#23692) with switched on/off Create New checkbox
• run factory from https://github.com/che-incubator/quarkus-api-example.git?new
• run factory from https://gitlab-gitlab-system.apps.git.crw-qe.com/test-user/public-gitlab-repo.git/-/tree/refreshToken?new
• run factory from raw devfile https://gitlab-gitlab-system.apps.git.crw-qe.com/api/v4/projects/10/repository/files/devfile.yaml/raw?ref=master&private_token=xxxx

Creating an existing/new workspace associated with the "Create new" checkbox works correctly.
The "trust the authors of this repository" popup functionality works as expected.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: artaleks9, olexii4, svor, vinokurig

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment