-
Notifications
You must be signed in to change notification settings - Fork 58
Fix Trust the Authors dialog not responding to Continue action #1440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1440 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1440", name: che-dashboard}]}}]" |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1440 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1440", name: che-dashboard}]}}]" |
c824b4e to
b805aba
Compare
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1440 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1440", name: che-dashboard}]}}]" |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1440 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1440", name: che-dashboard}]}}]" |
Assisted-by: Claude Opus 4.5 Signed-off-by: Oleksii Orel <oorel@redhat.com>
svor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't reproduce the issue, tested with image from PR
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1440 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1440", name: che-dashboard}]}}]" |
|
/retest |
1 similar comment
|
/retest |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1440 +/- ##
=======================================
Coverage 92.77% 92.78%
=======================================
Files 520 521 +1
Lines 48983 49037 +54
Branches 3643 3647 +4
=======================================
+ Hits 45446 45499 +53
- Misses 3499 3500 +1
Partials 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Verified on Eclipce Che deployed on OCP v20 with The functionality works as expected. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: artaleks9, olexii4, svor The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What does this PR do?
This PR fixes the "Trust the Authors" dialog not responding to the Continue action. When clicking Continue, the dialog would not close and the workspace would not start, showing a 500 Internal Server Error.
The root cause was a breaking change in the
@kubernetes/client-node1.4.0 API update. The new API automatically selectsapplication/json-patch+jsonas the Content-Type for PATCH requests, which requires a JSON Patch format (array with op/path/value).Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23704
Is it tested? How?
https://<che-host>/dashboard/#https://github.com/user/new-repo)Release Notes
Docs PR