Skip to content

Conversation

@olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jan 6, 2026

What does this PR do?

This PR fixes the "Trust the Authors" dialog not responding to the Continue action. When clicking Continue, the dialog would not close and the workspace would not start, showing a 500 Internal Server Error.

The root cause was a breaking change in the @kubernetes/client-node 1.4.0 API update. The new API automatically selects application/json-patch+json as the Content-Type for PATCH requests, which requires a JSON Patch format (array with op/path/value).

Screenshot/screencast of this PR

Знімок екрана 2026-01-06 о 16 57 44

What issues does this PR fix or reference?

fixes eclipse-che/che#23704

Is it tested? How?

  1. Deploy Eclipse-Che with the image from this PR
  2. Create a workspace from a factory URL that has not been trusted before (e.g., https://<che-host>/dashboard/#https://github.com/user/new-repo)
  3. The "Trust the authors of this repository" dialog appears
  4. Click the "Continue" button
  5. Expected: The dialog closes and the workspace starts creating

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Jan 6, 2026

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1440

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1440", name: che-dashboard}]}}]"

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1440

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1440", name: che-dashboard}]}}]"

@olexii4 olexii4 force-pushed the CHE-23704 branch 6 times, most recently from c824b4e to b805aba Compare January 6, 2026 15:34
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1440

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1440", name: che-dashboard}]}}]"

@olexii4 olexii4 requested a review from svor January 6, 2026 15:45
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1440

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1440", name: che-dashboard}]}}]"

@svor svor requested a review from artaleks9 January 6, 2026 15:47
Assisted-by: Claude Opus 4.5
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't reproduce the issue, tested with image from PR

@openshift-ci openshift-ci bot added the lgtm label Jan 6, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1440

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1440", name: che-dashboard}]}}]"

@svor
Copy link
Contributor

svor commented Jan 6, 2026

/retest

1 similar comment
@artaleks9
Copy link
Contributor

/retest

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 93.22034% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.78%. Comparing base (e089ade) to head (79f08ac).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...evworkspaceClient/services/helpers/patchOptions.ts 94.11% 3 Missing ⚠️
...orkspaceClient/services/workspacePreferencesApi.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1440   +/-   ##
=======================================
  Coverage   92.77%   92.78%           
=======================================
  Files         520      521    +1     
  Lines       48983    49037   +54     
  Branches     3643     3647    +4     
=======================================
+ Hits        45446    45499   +53     
- Misses       3499     3500    +1     
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@artaleks9
Copy link
Contributor

Verified on Eclipce Che deployed on OCP v20 with quay.io/eclipse/che-dashboard:pr-1440.

The functionality works as expected.

@openshift-ci
Copy link

openshift-ci bot commented Jan 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: artaleks9, olexii4, svor

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svor svor merged commit 82de37b into main Jan 7, 2026
19 checks passed
@svor svor deleted the CHE-23704 branch January 7, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dashboard] Trust the Authors dialog does not respond to Continue action

5 participants