Conversation
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1442 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1442", name: che-dashboard}]}}]" |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
==========================================
- Coverage 92.77% 92.77% -0.01%
==========================================
Files 521 521
Lines 49338 49351 +13
Branches 3703 3699 -4
==========================================
+ Hits 45775 45786 +11
- Misses 3524 3526 +2
Partials 39 39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1442 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1442", name: che-dashboard}]}}]" |
|
/retest |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1442 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1442", name: che-dashboard}]}}]" |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olexii4, svor, tolusha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Enable dashboard to work in IPv6-only environments by updating server bindings and URL validation patterns to support IPv6 bracket notation (e.g., http://[::1]:8080). - Backend server binds to '::' for dual-stack support - Factory and git URL regex support IPv6 literal addresses - Container registry validation supports IPv6 - Added IPv6 test coverage Fixes eclipse-che/che#23674 Assisted-by: Claude Sonnet 4.5 Signed-off-by: Oleksii Orel <oorel@redhat.com>
|
New changes are detected. LGTM label has been removed. |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1442 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1442", name: che-dashboard}]}}]" |
Updated HTTP URL regex to include dots in IPv6 character class to support IPv4-mapped IPv6 addresses (e.g., ::ffff:192.168.1.1). The previous regex rejected URLs like http://[::ffff:10.217.0.98]:8080/repo.git because it didn't recognize dots within IPv6 brackets. This caused the URL to be incorrectly identified as an SSH location, triggering SSH key validation errors for HTTP URLs. Changes: - Updated isHttpLocation regex: [0-9a-fA-F:] → [0-9a-fA-F:.] - Added test cases for IPv4-mapped IPv6 addresses Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Oleksii Orel <oorel@redhat.com>
Added documentation for HOST_USERS environment variable functionality to ensure it remains available for controlling host user capabilities in DevWorkspace containers. The HOST_USERS env var is used to configure whether containers run with host user capabilities, which is essential for certain SCC configurations: - Set to 'false' for container-run SCC (rootless containers) - Set to 'true' for container-build SCC (requires host user access) This functionality is maintained despite PR #1436 proposing its removal, as it remains necessary for proper SCC attribute management. Changes: - Added inline documentation for hostUsersEnvName field - Added JSDoc comments for setHostUsersEnvVar() method - Added JSDoc comments for removeHostUsersEnvVar() method Signed-off-by: Oleksii Orel <oorel@redhat.com>
13429ed to
d71c288
Compare
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1442 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1442", name: che-dashboard}]}}]" |
1 similar comment
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1442 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1442", name: che-dashboard}]}}]" |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1442 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1442", name: che-dashboard}]}}]" |

What does this PR do?
This PR adds IPv6 support in Eclipse Che Dashboard to enable operation in IPv6-only network environments. As Kubernetes platforms (particularly OpenShift Container Platform 4.20) migrate to IPv6, the dashboard must handle IPv6 addresses correctly in URLs, API calls, and server bindings.
The implementation involved minimal, focused changes to URL validation patterns and server configuration, enabling full IPv6 support while maintaining complete backward compatibility with IPv4-only and dual-stack environments.
Background
The Eclipse Che Dashboard previously failed to operate in IPv6-only environments due to:
0.0.0.0(IPv4-only)http://[::1]:8080)Impact
IPv6 Bracket Notation
IPv6 addresses in URLs require square brackets to distinguish the address from port numbers:
http://[2001:db8::1]:8080/repo.githttp://2001:db8::1:8080/repo.git(ambiguous - is8080part of address or port?)Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23674
Is it tested? How?
Tested manually on an IPv6-only OpenShift cluster (OCP 4.20.x) using the deployment + validation scripts in the testing repository:
https://github.com/olexii4/deploy-che-ipv6-chectl.gitHow to reproduce the test:
./scripts/mirror-images-to-registry.sh \ --mode full \ --prefetch-only \ --cache-dir ~/.cache/che-ipv6-mirrorNotes:
ImageTagMirrorSet/ImageDigestMirrorSet(+ ICSP for compatibility).scripts/mirror-images-to-registry.md.skopeo copyis guarded by a per-image timeout (SKOPEO_TIMEOUT_SECONDS, default 900s) to avoid hangs.All required commands and expected outputs are documented in the repository
README.md.Release Notes
Docs PR