Skip to content

Conversation

@dkwon17
Copy link
Contributor

@dkwon17 dkwon17 commented Jan 3, 2025

What does this pull request change?

This PR updates the "Enabling fuse-overlayfs for all workspaces" doc such that they work with Podman 5.x. This PR is in response to devfile/developer-images#209

What issues does this pull request fix or reference?

Related PR: devfile/developer-images#209

Specify the version of the product this pull request applies to

Che 7.95

Screenshot From 2025-01-03 14-30-11

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@github-actions
Copy link

github-actions bot commented Jan 3, 2025

🎊 Navigate the preview: https://6797d49eb407dc448285ceb3--eclipse-che-docs-pr.netlify.app 🎊

@github-actions
Copy link

github-actions bot commented Jan 3, 2025

Click here to review and test in web IDE: Contribute

@dkwon17 dkwon17 force-pushed the fuseupdate branch 3 times, most recently from c756db3 to 3df0d02 Compare January 3, 2025 16:41
Signed-off-by: dkwon17 <dakwon@redhat.com>
@dkwon17 dkwon17 marked this pull request as ready for review January 3, 2025 19:37
@dkwon17 dkwon17 requested review from a team and deerskindoll as code owners January 3, 2025 19:37
@dkwon17 dkwon17 requested a review from nickboldt January 3, 2025 19:37
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of questions

Signed-off-by: dkwon17 <dakwon@redhat.com>
@dkwon17
Copy link
Contributor Author

dkwon17 commented Jan 6, 2025

@deerskindoll thank you for the review, I've made some changes

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the doc a bit to make it easier to follow. Let me know what you think.

dkwon17 and others added 4 commits January 17, 2025 14:15
…paces.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…paces.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…paces.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
Signed-off-by: dkwon17 <dakwon@redhat.com>
@dkwon17
Copy link
Contributor Author

dkwon17 commented Jan 17, 2025

@deerskindoll sorry for the late feedback, I've added some new comments

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed formatting

…paces.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
@dkwon17 dkwon17 mentioned this pull request Jan 28, 2025
5 tasks
@dkwon17
Copy link
Contributor Author

dkwon17 commented Jan 28, 2025

Replaced by #2859

@dkwon17 dkwon17 closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants