Skip to content

chore: Mount proxy env variables to dashboard container #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tolusha merged 1 commit into from
Jan 8, 2025
Merged

chore: Mount proxy env variables to dashboard container #1950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion pkg/deploy/dashboard/deployment_dashboard.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,30 @@ func (d *DashboardReconciler) getDashboardDeploymentSpec(ctx *chetypes.DeployCon
// They are used to replace images with tags on images with digests.
envVars := utils.GetGetArchitectureDependentEnvsByRegExp("^RELATED_IMAGE_sample_.*$")
envVars = append(envVars,
// todo handle HTTP_PROXY related env vars
corev1.EnvVar{
Name: "http_proxy",
Value: ctx.Proxy.HttpProxy,
},
corev1.EnvVar{
Name: "https_proxy",
Value: ctx.Proxy.HttpsProxy,
},
corev1.EnvVar{
Name: "no_proxy",
Value: ctx.Proxy.NoProxy,
},
corev1.EnvVar{
Name: "HTTP_PROXY",
Value: ctx.Proxy.HttpProxy,
},
corev1.EnvVar{
Name: "HTTPS_PROXY",
Value: ctx.Proxy.HttpsProxy,
},
corev1.EnvVar{
Name: "NO_PROXY",
Value: ctx.Proxy.NoProxy,
},
// CHE_HOST is here for backward compatibility. Replaced with CHE_URL
corev1.EnvVar{
Name: "CHE_HOST",
Expand Down
Loading