chore: update dependencies to the latest versions #2016

tolusha · 2025-07-24T11:56:59Z

What does this PR do?

Update project dependencies, specifically github.com/operator-framework/api to have ability to set userNamespaceLevel in SCC

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-8320

How to test this PR?

Prepare a patch file if needed:

cat > /tmp/cr-patch.yaml <<EOF
apiVersion: org.eclipse.che/v2
kind: CheCluster
spec: {}
EOF

Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

.github/workflows/pr-check.yml

tolusha · 2025-07-29T07:05:53Z

/retest

Signed-off-by: Anatolii Bazko <[email protected]>

rohanKanojia · 2025-07-29T14:59:00Z

.github/workflows/pr-check.yml

        check-license-header -f "${LICENSE_TEMPLATE}" ${FILES_TO_CHECK_LICENSE}
-  dependencies-md-validation:
+  dependencies-validation:
    runs-on: ubuntu-22.04


nit, use latest version of ubuntu runner, either use ubuntu-latest or 24.04 or ubuntu-24.04-arm

Suggested change

runs-on: ubuntu-22.04

runs-on: ubuntu-24.04

rohanKanojia · 2025-07-29T14:59:18Z

.github/workflows/pr-check.yml

-      env:
-        EXCLUDE_DEPS: "github.com/bmizerany/assert, gotest.tools/v3, github.com/dhui/dktest, gotest.tools, github.com/golangplus/testing"
+      - name: Checkout source code
+        uses: actions/checkout@v3


Suggested change

uses: actions/checkout@v3

uses: actions/checkout@v4

rohanKanojia · 2025-07-29T15:27:25Z

DEPENDENCIES.md

Sorry for naive question,
Is DEPENDENCIES.md intentionally removed due to deprecation, redundancy, or is the information tracked elsewhere now?

Yes, it was intentionally removed and replaced by a PR check.
I've added build/scripts/clear-defined-test.sh to automatically check licenses.

rohanKanojia · 2025-07-29T15:34:50Z

cmd/main.go

+		os.Exit(1)
+	}
+
+	namespacechace := namespacecache.NewNamespaceCache(nonCachingClient)


typo

Suggested change

namespacechace := namespacecache.NewNamespaceCache(nonCachingClient)

namespacecache := namespacecache.NewNamespaceCache(nonCachingClient)

rohanKanojia · 2025-07-29T15:40:56Z

cmd/main.go

+	"github.com/devfile/devworkspace-operator/pkg/infrastructure"
+	devworkspaceinfra "github.com/devfile/devworkspace-operator/pkg/infrastructure"


nit, I see IsOpenShift() getting used in this class with these duplicated packages. Is it okay to delete one?

infrastructure.IsOpenShift()

devworkspaceinfra.IsOpenShift()

Signed-off-by: Anatolii Bazko <[email protected]>

.github/workflows/pr-check.yml

To fix the problem, add a permissions block to the workflow file .github/workflows/pr-check.yml. This block should be placed at the top level (before jobs:) to apply to all jobs in the workflow, unless a job requires different permissions. The minimal starting point is contents: read, which allows jobs to read repository contents but not write. If any job requires additional permissions (such as pull-requests: write), those can be added as needed, but based on the current workflow, only read access is required.

Specifically, insert the following block after the name: and on: keys, and before jobs::

permissions: contents: read

No additional imports, methods, or definitions are required.

.github/workflows/pr-check.yml

To fix the problem, add a permissions block at the top level of the workflow file (.github/workflows/pr-check.yml), just below the name: and before the on: key. This will apply the specified permissions to all jobs in the workflow unless overridden at the job level. The minimal recommended permissions are contents: read, which allows jobs to read repository contents but not write to them. If any job needs to write to pull requests (e.g., to post comments or statuses), you can add pull-requests: write, but based on the provided steps, only contents: read is required. No additional imports or definitions are needed.

tolusha · 2025-07-30T06:53:05Z

Remarks have been fixed.
Thank you for review.

tolusha · 2025-07-30T08:50:46Z

/retest

rohanKanojia · 2025-07-30T08:59:53Z

controllers/devworkspace/controller_test.go

-		t.Fatalf("Failed to update the manager in the fake client: %s", err)
-	}
+	// It is not possible to update readonly field
+	//manager.DeletionTimestamp = &metav1.Time{Time: time.Now()}


Would it be possible to simulate deletion by calling client.Delete() instead of manually setting .DeletionTimestamp?

Does the fake client automatically set .DeletionTimestamp when Delete() is called, or would we need to mock that behavior manually for finalizer testing?

Thank you for the hint.
Fake client does set DeletionTimestamp, the test was updated accordingly.

openshift-ci · 2025-07-30T09:01:54Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohanKanojia, tolusha

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <[email protected]>

openshift-ci · 2025-07-30T09:20:16Z

New changes are detected. LGTM label has been removed.

tolusha · 2025-07-30T11:06:21Z

/retest

tolusha · 2025-07-30T12:00:30Z

It seems ci/prow/v19-devworkspace-happy-path job is quite unstable.
Local results are fine:

  9 passing (4m)
...
[INFO] Happy-path test succeed.
[INFO] Happy-path execution took 368.911734906 seconds.

tolusha requested review from SDawley, ibuziuk and mkuznyetsov as code owners July 24, 2025 11:57

openshift-merge-robot added the needs-rebase label Jul 24, 2025

github-advanced-security bot found potential problems Jul 24, 2025

View reviewed changes

.github/workflows/pr-check.yml Fixed Show fixed Hide fixed

tolusha force-pushed the updatedependencies branch from d3e7a3c to 340425e Compare July 28, 2025 14:39

openshift-merge-robot removed the needs-rebase label Jul 28, 2025

tolusha force-pushed the updatedependencies branch from 340425e to 2de584b Compare July 28, 2025 15:49

tolusha changed the title ~~chore: update project dependencies~~ chore: update project dependencies to the latest versions Jul 28, 2025

tolusha changed the title ~~chore: update project dependencies to the latest versions~~ chore: update dependencies to the latest versions Jul 28, 2025

tolusha force-pushed the updatedependencies branch from 0ea494f to f7dd97c Compare July 29, 2025 13:47

openshift-merge-robot added the needs-rebase label Jul 29, 2025

tolusha force-pushed the updatedependencies branch from f7dd97c to 0e0fe88 Compare July 29, 2025 13:56

openshift-merge-robot removed the needs-rebase label Jul 29, 2025

tolusha force-pushed the updatedependencies branch 2 times, most recently from 95a064d to e8d1b43 Compare July 29, 2025 14:01

openshift-merge-robot added the needs-rebase label Jul 29, 2025

tolusha added 3 commits July 29, 2025 16:04

Add vendor folder

d76219e

Signed-off-by: Anatolii Bazko <[email protected]>

Add rest of the changes

ab08085

Signed-off-by: Anatolii Bazko <[email protected]>

Fixup after merge

d59b64b

Signed-off-by: Anatolii Bazko <[email protected]>

tolusha force-pushed the updatedependencies branch from e8d1b43 to d59b64b Compare July 29, 2025 14:06

openshift-merge-robot removed the needs-rebase label Jul 29, 2025

tolusha requested a review from rohanKanojia July 29, 2025 14:28

rohanKanojia reviewed Jul 29, 2025

View reviewed changes

fix remarks

488a9a6

Signed-off-by: Anatolii Bazko <[email protected]>

github-advanced-security bot found potential problems Jul 30, 2025

View reviewed changes

rohanKanojia reviewed Jul 30, 2025

View reviewed changes

rohanKanojia approved these changes Jul 30, 2025

View reviewed changes

openshift-ci bot assigned rohanKanojia Jul 30, 2025

openshift-ci bot added the lgtm label Jul 30, 2025

rohanKanojia removed their assignment Jul 30, 2025

fix test

940de6f

Signed-off-by: Anatolii Bazko <[email protected]>

openshift-ci bot removed the lgtm label Jul 30, 2025

tolusha merged commit 6d33703 into main Jul 30, 2025
31 of 33 checks passed

tolusha deleted the updatedependencies branch July 30, 2025 12:28

@@ -13,2 +13,4 @@
             name: PR check
+            permissions:
+              contents: read
             on: pull_request

	namespacechace := namespacecache.NewNamespaceCache(nonCachingClient)
	namespacecache := namespacecache.NewNamespaceCache(nonCachingClient)

		"github.com/devfile/devworkspace-operator/pkg/infrastructure"
		devworkspaceinfra "github.com/devfile/devworkspace-operator/pkg/infrastructure"

chore: update dependencies to the latest versions #2016

chore: update dependencies to the latest versions #2016

Uh oh!

Conversation

tolusha commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

OpenShift

on Minikube

PR Checklist

Reviewers

Uh oh!

Uh oh!

tolusha commented Jul 29, 2025

Uh oh!

rohanKanojia Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rohanKanojia Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

rohanKanojia Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

tolusha Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

rohanKanojia Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

rohanKanojia Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

Check warning

Copilot Autofix

Check warning

Copilot Autofix

tolusha commented Jul 30, 2025

Uh oh!

tolusha commented Jul 30, 2025

Uh oh!

rohanKanojia Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

tolusha Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jul 30, 2025

Uh oh!

openshift-ci bot commented Jul 30, 2025

Uh oh!

tolusha commented Jul 30, 2025

Uh oh!

tolusha commented Jul 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tolusha commented Jul 24, 2025 •

edited

Loading

rohanKanojia Jul 29, 2025 •

edited

Loading