Skip to content

Conversation

@tolusha
Copy link
Contributor

@tolusha tolusha commented Oct 8, 2025

What does this PR do?

Add eclipse-che-edit and eclipse-che-view ClusterRoles to provide standardized RBAC permissions for Eclipse Che administration. These roles follow Kubernetes conventions for edit/view access patterns and enable
fine-grained access control for Eclipse Che resources

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#23580

How to test this PR?

  1. Prepare a patch file if needed:
cat > /tmp/cr-patch.yaml <<EOF
apiVersion: org.eclipse.che/v2
kind: CheCluster
spec: {}
EOF
  1. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tolusha tolusha marked this pull request as ready for review October 8, 2025 14:26
@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha
Copy link
Contributor Author

tolusha commented Oct 9, 2025

@ibuziuk @cgruver
Could you have a look pls, is it ok for you?

Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
@tolusha
Copy link
Contributor Author

tolusha commented Oct 14, 2025

/retest

@tolusha tolusha merged commit 3e68cdf into main Oct 14, 2025
21 checks passed
@tolusha tolusha deleted the eclipscheeditviewroles branch October 14, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants