Skip to content

chore: initContainers field#2084

Merged
tolusha merged 3 commits intomainfrom
23706
Feb 6, 2026
Merged

chore: initContainers field#2084
tolusha merged 3 commits intomainfrom
23706

Conversation

@tolusha
Copy link
Contributor

@tolusha tolusha commented Feb 5, 2026

What does this PR do?

eclipse-che/che#23706

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#23706

How to test this PR?

  1. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh

or

build/scripts/docker-run.sh /bin/bash -c "
  oc login \
    --token=<...> \
    --server=<...> \
    --insecure-skip-tls-verify=true && \
  build/scripts/olm/test-catalog-from-sources.sh
"

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh

Common Test Scenarios

  • Deploy Eclipse Che
  • Start an empty workspace
  • Open terminal and build/run an image
  • Stop a workspace
  • Check operator logs for reconciliation errors or infinite reconciliation loops

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link

@akurinnoy akurinnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it worth to add some unit tests for the new functionality before merge.

@openshift-ci
Copy link

openshift-ci bot commented Feb 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, rohanKanojia, tolusha

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha
Copy link
Contributor Author

tolusha commented Feb 5, 2026

/retest

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Feb 6, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 6, 2026

New changes are detected. LGTM label has been removed.

@tolusha tolusha merged commit e45c233 into main Feb 6, 2026
21 checks passed
@tolusha tolusha deleted the 23706 branch February 6, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants