Skip to content

Comments

[Test] Adapt Podman tests to airgap disconnected cluster#23407

Merged
dmytro-ndp merged 1 commit intoeclipse-che:mainfrom
martinszuc:CRW-8365
Apr 22, 2025
Merged

[Test] Adapt Podman tests to airgap disconnected cluster#23407
dmytro-ndp merged 1 commit intoeclipse-che:mainfrom
martinszuc:CRW-8365

Conversation

@martinszuc
Copy link
Contributor

@martinszuc martinszuc commented Apr 10, 2025

What does this PR do?

BuildPushRunPodmanContainerAPI & KubedockPodmanTest now use dockerfile-hello-world from internal and public github repositories available on airgap & online clusters.
Solution:

Successful test runs:
online:

airgap:

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-8365

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

martinszuc added a commit to martinszuc/che that referenced this pull request Apr 10, 2025
…#23407)

BuildPushRunPodmanContainerAPI & KubedockPodmanTest now use dockerfile-hello-world from enterprise and public github repositories

Signed-off-by: Martin Szuc <mszuc@redhat.com>
martinszuc added a commit to martinszuc/che that referenced this pull request Apr 10, 2025
…#23407)

BuildPushRunPodmanContainerAPI & KubedockPodmanTest now use dockerfile-hello-world from enterprise and public github repositories

Signed-off-by: Martin Szuc <mszuc@redhat.com>
Copy link
Contributor

@SkorikSergey SkorikSergey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

@dmytro-ndp dmytro-ndp requested a review from Copilot April 11, 2025 18:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

tests/e2e/specs/api/BuildPushRunPodmanContainerAPI.spec.ts:51

  • Ensure that the file Dockerfile.${ARCH} exists in the $PROJECT_SOURCE directory, as the previous auto-generated Dockerfile creation has been removed. Adding a check or a clear comment on the expected source of this file could help avoid build failures.
podman build -t "${IMG}" -f Dockerfile.${ARCH} .

@dmytro-ndp
Copy link
Contributor

@martinszuc : the suggesting which Copilot made in his comment above sounds reasonable, IMHO.

Would you, please, include a verification step for the presence of the Dockerfile in the project, with a meaningful error message?

martinszuc added a commit to martinszuc/che that referenced this pull request Apr 15, 2025
…#23407)

BuildPushRunPodmanContainerAPI & KubedockPodmanTest now use dockerfile-hello-world
from internal and public github repositories

Added TS_SELENIUM_AIRGAP_FACTORY_GIT_REPO_URL environment variable to support
factory URLs specifically for disconnected environments

Signed-off-by: Martin Szuc <mszuc@redhat.com>
…#23407)

BuildPushRunPodmanContainerAPI & KubedockPodmanTest now use dockerfile-hello-world
from internal and public github repositories

Added TS_SELENIUM_AIRGAP_FACTORY_GIT_REPO_URL environment variable to support
factory URLs specifically for disconnected environments

Signed-off-by: Martin Szuc <mszuc@redhat.com>
@martinszuc
Copy link
Contributor Author

martinszuc commented Apr 15, 2025

@martinszuc : the suggesting which Copilot made in his comment above sounds reasonable, IMHO.

Would you, please, include a verification step for the presence of the Dockerfile in the project, with a meaningful error message?

Actually useful review! Copilot found that step - Check the project files were imported was missing in BuildPushRunPodmanAPI test

	test('Check the project files were imported', async function (): Promise<void> {
		const projectSection: ViewSection = await projectAndFileTests.getProjectViewSession();
		expect(await projectAndFileTests.getProjectTreeItem(projectSection, 'Dockerfile.x86_64'), 'Dockerfile not found in the project tree').not.undefined;
	});

added it into test suite setup

@martinszuc martinszuc requested a review from dmytro-ndp April 15, 2025 15:55
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge

@dmytro-ndp dmytro-ndp merged commit 36ecc36 into eclipse-che:main Apr 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants