[Test] Adapt Podman tests to airgap disconnected cluster#23407
[Test] Adapt Podman tests to airgap disconnected cluster#23407dmytro-ndp merged 1 commit intoeclipse-che:mainfrom
Conversation
…#23407) BuildPushRunPodmanContainerAPI & KubedockPodmanTest now use dockerfile-hello-world from enterprise and public github repositories Signed-off-by: Martin Szuc <mszuc@redhat.com>
…#23407) BuildPushRunPodmanContainerAPI & KubedockPodmanTest now use dockerfile-hello-world from enterprise and public github repositories Signed-off-by: Martin Szuc <mszuc@redhat.com>
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
tests/e2e/specs/api/BuildPushRunPodmanContainerAPI.spec.ts:51
- Ensure that the file Dockerfile.${ARCH} exists in the $PROJECT_SOURCE directory, as the previous auto-generated Dockerfile creation has been removed. Adding a check or a clear comment on the expected source of this file could help avoid build failures.
podman build -t "${IMG}" -f Dockerfile.${ARCH} .
|
@martinszuc : the suggesting which Copilot made in his comment above sounds reasonable, IMHO. Would you, please, include a verification step for the presence of the |
…#23407) BuildPushRunPodmanContainerAPI & KubedockPodmanTest now use dockerfile-hello-world from internal and public github repositories Added TS_SELENIUM_AIRGAP_FACTORY_GIT_REPO_URL environment variable to support factory URLs specifically for disconnected environments Signed-off-by: Martin Szuc <mszuc@redhat.com>
…#23407) BuildPushRunPodmanContainerAPI & KubedockPodmanTest now use dockerfile-hello-world from internal and public github repositories Added TS_SELENIUM_AIRGAP_FACTORY_GIT_REPO_URL environment variable to support factory URLs specifically for disconnected environments Signed-off-by: Martin Szuc <mszuc@redhat.com>
Actually useful review! Copilot found that step - added it into test suite setup |
What does this PR do?
BuildPushRunPodmanContainerAPI & KubedockPodmanTest now use dockerfile-hello-world from internal and public github repositories available on airgap & online clusters.
Solution:
TS_SELENIUM_AIRGAP_FACTORY_GIT_REPO_URLto specify Git repository URL for disconnected environmentsSuccessful test runs:
online:
airgap:
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-8365
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.