Skip to content

Comments

Automate testing an ability to disable "Install from VSIX..." functionality#23454

Merged
dmytro-ndp merged 3 commits intoeclipse-che:mainfrom
martinszuc:CRW-8655
Jun 26, 2025
Merged

Automate testing an ability to disable "Install from VSIX..." functionality#23454
dmytro-ndp merged 3 commits intoeclipse-che:mainfrom
martinszuc:CRW-8655

Conversation

@martinszuc
Copy link
Contributor

@martinszuc martinszuc commented Jun 6, 2025

What does this PR do?

This PR adds a comprehensive end-to-end test that validates the ability to disable "Install from VSIX..." functionality in DevSpaces workspaces through ConfigMap configuration. The test implements the complete U77 test scenario and verifies:

When VSIX installation is disabled:

  • "Install from VSIX" command is not available in Command Palette (F1 menu)
  • "Install from VSIX" action is not available in Extensions view More Actions menu
  • "Install Extension VSIX" action is not available in Explorer context menu for .vsix files
  • Default VSIX extensions are NOT auto-installed during workspace startup
  • Proper notification is displayed when VSIX installation is disabled

When VSIX installation is enabled (regression test):

  • All "Install from VSIX" UI elements are properly available
  • Default VSIX extensions ARE auto-installed during workspace startup
  • Existing functionality works as expected

The test includes new page objects and utilities for:

  • CommandPalette - For testing command palette interactions
  • ExtensionsView - For testing extensions view menu interactions
  • ExplorerView - For testing file explorer context menu interactions
  • NotificationHandler - For checking workspace notifications
  • ConfigMap management utilities for test setup and cleanup

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-8655

How to test this PR?

  1. Run the test:
export USERSTORY=VsixInstallationDisableTest
export NODE_TLS_REJECT_UNAUTHORIZED=0
export TS_OCP_LOGIN_PAGE_PROVIDER_TITLE=htpasswd
export TS_SELENIUM_VALUE_OPENSHIFT_OAUTH=true
export TS_SELENIUM_HEADLESS=false
export OCP_VERSION=4.18
export TS_SELENIUM_BASE_URL=https://devspaces.apps....
export OCP_CONSOLE_URL=https://console-openshift-console.apps.....
export TS_SELENIUM_OCP_PASSWORD=
export TS_SELENIUM_OCP_USERNAME=

npm run test

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@martinszuc martinszuc changed the title Automate testing an ability to disable "Install from VSIX..." functionality [DRAFT] Automate testing an ability to disable "Install from VSIX..." functionality Jun 6, 2025
@martinszuc martinszuc force-pushed the CRW-8655 branch 11 times, most recently from 3d94c5a to cb42363 Compare June 13, 2025 10:28
@martinszuc martinszuc changed the title [DRAFT] Automate testing an ability to disable "Install from VSIX..." functionality Automate testing an ability to disable "Install from VSIX..." functionality Jun 13, 2025
@martinszuc martinszuc marked this pull request as ready for review June 13, 2025 10:49
@martinszuc martinszuc force-pushed the CRW-8655 branch 6 times, most recently from 8303d77 to 5cc499d Compare June 16, 2025 15:56
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commonly PR looks good to merge, with a few non-critical notices.

Well done, @martinszuc !

@ibuziuk
Copy link
Member

ibuziuk commented Jun 20, 2025

@martinszuc @dmytro-ndp are we good to merge?

@martinszuc
Copy link
Contributor Author

martinszuc commented Jun 20, 2025

@martinszuc @dmytro-ndp are we good to merge?

@ibuziuk No it's not, code needs some refactoring and cleanup according to dmytros comment.

I plan to take a look during weekend. So probably it should be ready by Monday.

Prevents "devspaces.com wants to see text and images copied to the
clipboard" popup when opening context menus on project files in
VS Code editor during e2e test execution.

Signed-off-by: Martin Szuc <mszuc@redhat.com>
…nstallation for vscode

Signed-off-by: Martin Szuc <mszuc@redhat.com>
@martinszuc martinszuc force-pushed the CRW-8655 branch 8 times, most recently from 7cc000e to 35d9b1f Compare June 25, 2025 13:12
Assisted-by: Gemini
Signed-off-by: Martin Szuc <mszuc@redhat.com>
@martinszuc
Copy link
Contributor Author

If reviewers have nothing more to add, the PR is READY for merge from my side :)

@dmytro-ndp dmytro-ndp merged commit 2338445 into eclipse-che:main Jun 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants