Add 'AnsibleDevFileAPI' E2E test by artaleks9 · Pull Request #23456 · eclipse-che/che

artaleks9 · 2025-06-10T08:48:56Z

What does this PR do?

Adds 'AnsibleDevFileAPI E2E test to api set tests
Adds methods to /tests/e2e/utils/KubernetesCommandLineToolsExecutor.ts pageobject

Screenshot/screencast of this PR

[ashmaraiev@fedora e2e]$ npm run prettier

> @eclipse-che/che-e2e@7.104.0-next prettier
> prettier --config .prettierrc.json . --write

.eslintrc.js 71ms (unchanged)
.prettierrc.json 2ms (unchanged)
CODE_STYLE.md 64ms (unchanged)
configs/inversify.config.ts 107ms (unchanged)
configs/inversify.types.ts 15ms (unchanged)
configs/mocharc.ts 14ms (unchanged)
configs/reporters.config.js 11ms (unchanged)
constants/API_TEST_CONSTANTS.ts 15ms (unchanged)
constants/BASE_TEST_CONSTANTS.ts 20ms (unchanged)
constants/CHROME_DRIVER_CONSTANTS.ts 10ms (unchanged)
constants/FACTORY_TEST_CONSTANTS.ts 9ms (unchanged)
constants/MOCHA_CONSTANTS.ts 5ms (unchanged)
constants/MONACO_CONSTANTS.ts 3ms (unchanged)
constants/OAUTH_CONSTANTS.ts 7ms (unchanged)
constants/PLUGIN_TEST_CONSTANTS.ts 3ms (unchanged)
constants/REPORTER_CONSTANTS.ts 17ms (unchanged)
constants/TIMEOUT_CONSTANTS.ts 13ms (unchanged)
driver/ChromeDriver.ts 19ms (unchanged)
driver/IDriver.ts 4ms (unchanged)
package-lock.json 115ms (unchanged)
package.json 3ms (unchanged)
pageobjects/dashboard/CreateWorkspace.ts 29ms (unchanged)
pageobjects/dashboard/Dashboard.ts 40ms (unchanged)
pageobjects/dashboard/TrustAuthorPopup.ts 7ms (unchanged)
pageobjects/dashboard/UserPreferences.ts 40ms (unchanged)
pageobjects/dashboard/workspace-details/WorkspaceDetails.ts 31ms (unchanged)
pageobjects/dashboard/Workspaces.ts 50ms (unchanged)
pageobjects/git-providers/OauthPage.ts 26ms (unchanged)
pageobjects/ide/CheCodeLocatorLoader.ts 13ms (unchanged)
pageobjects/ide/RestrictedModeButton.ts 3ms (unchanged)
pageobjects/ide/ViewsMoreActionsButton.ts 6ms (unchanged)
pageobjects/login/interfaces/ICheLoginPage.ts 2ms (unchanged)
pageobjects/login/interfaces/IOcpLoginPage.ts 2ms (unchanged)
pageobjects/login/kubernetes/DexLoginPage.ts 8ms (unchanged)
pageobjects/login/kubernetes/KubernetesLoginPage.ts 4ms (unchanged)
pageobjects/login/openshift/OcpLoginPage.ts 12ms (unchanged)
pageobjects/login/openshift/OcpRedHatLoginPage.ts 7ms (unchanged)
pageobjects/login/openshift/OcpUserLoginPage.ts 5ms (unchanged)
pageobjects/login/openshift/RedHatLoginPage.ts 9ms (unchanged)
pageobjects/login/openshift/RegularUserOcpCheLoginPage.ts 9ms (unchanged)
pageobjects/openshift/OcpApplicationPage.ts 7ms (unchanged)
pageobjects/openshift/OcpImportFromGitPage.ts 10ms (unchanged)
pageobjects/openshift/OcpMainPage.ts 15ms (unchanged)
pageobjects/webterminal/WebTerminalPage.ts 24ms (unchanged)
README.md 29ms (unchanged)
specs/api/AnsibleDevFileAPI.spec.ts 69ms (unchanged)
specs/api/BuildPushRunPodmanContainerAPI.spec.ts 31ms (unchanged)
specs/api/ContainerOverridesAPI.spec.ts 8ms (unchanged)
specs/api/CppDevFileAPI.spec.ts 22ms (unchanged)
specs/api/DevfileAcceptanceTestAPI.spec.ts 25ms (unchanged)
specs/api/DotnetDevFileAPI.spec.ts 23ms (unchanged)
specs/api/EmptyWorkspaceAPI.spec.ts 13ms (unchanged)
specs/api/GoDevFileAPI.spec.ts 19ms (unchanged)
specs/api/InbuiltApplicationDevWorkspacesAPI.spec.ts 29ms (unchanged)
specs/api/JBossEapDevFileAPI.spec.ts 25ms (unchanged)
specs/api/LombokDevFileAPI.spec.ts 16ms (unchanged)
specs/api/NodeJsExpressDevFileAPI.spec.ts 36ms (unchanged)
specs/api/NodeJSMongoDBDevFileAPI.spec.ts 26ms (unchanged)
specs/api/PhpDevFileAPI.spec.ts 14ms (unchanged)
specs/api/PodOverridesAPI.spec.ts 9ms (unchanged)
specs/api/PythonDevFileAPI.spec.ts 14ms (unchanged)
specs/api/QuarkusDevFileAPI.spec.ts 16ms (unchanged)
specs/dashboard-samples/Documentation.spec.ts 28ms (unchanged)
specs/dashboard-samples/EmptyWorkspace.spec.ts 12ms (unchanged)
specs/dashboard-samples/Quarkus.spec.ts 9ms (unchanged)
specs/dashboard-samples/RecommendedExtensions.spec.ts 74ms (unchanged)
specs/devconsole-intergration/DevConsoleIntegration.spec.ts 15ms (unchanged)
specs/factory/Factory.spec.ts 41ms (unchanged)
specs/factory/FactoryWithGitRepoOptions.spec.ts 12ms (unchanged)
specs/factory/NoSetupRepoFactory.spec.ts 40ms (unchanged)
specs/factory/RefusedOAuthFactory.spec.ts 39ms (unchanged)
specs/miscellaneous/CreateWorkspaceWithExistedName.spec.ts 15ms (unchanged)
specs/miscellaneous/CustomOpenVSXRegistry.spec.ts 39ms (unchanged)
specs/miscellaneous/KubedockPodmanTest.spec.ts 14ms (unchanged)
specs/miscellaneous/PredefinedNamespace.spec.ts 11ms (unchanged)
specs/miscellaneous/RevokeOauth.spec.ts 4ms (unchanged)
specs/miscellaneous/UserPreferencesTest.spec.ts 7ms (unchanged)
specs/miscellaneous/UserSecretsInWorkspace.spec.ts 10ms (unchanged)
specs/miscellaneous/WorkspaceIdleTimeout.spec.ts 12ms (unchanged)
specs/miscellaneous/WorkspaceRunTimeout.spec.ts 16ms (unchanged)
specs/miscellaneous/WorkspaceWithParent.spec.ts 21ms (unchanged)
specs/MochaHooks.ts 16ms (unchanged)
specs/SmokeTest.spec.ts 12ms (unchanged)
specs/web-terminal/WebTerminalTest.spec.ts 10ms (unchanged)
specs/web-terminal/WebTerminalUnderAdmin.spec.ts 12ms (unchanged)
specs/web-terminal/WebTerminalUnderRegularUser.spec.ts 8ms (unchanged)
suites/devfile-acceptance-test-suite/DynamicallyGeneratingAPITest.suite.ts 2ms (unchanged)
suites/disconnected-ocp/APITest.suite.ts 3ms (unchanged)
suites/disconnected-ocp/DynamicallyGeneratingAPITest.suite.ts 2ms (unchanged)
suites/disconnected-ocp/UITest.suite.ts 2ms (unchanged)
suites/online-ocp/APITest.suite.ts 2ms (unchanged)
suites/online-ocp/DynamicallyGeneratingAPITest.suite.ts 1ms (unchanged)
suites/online-ocp/UITest.suite.ts 1ms (unchanged)
tests-library/LoginTests.ts 6ms (unchanged)
tests-library/ProjectAndFileTests.ts 15ms (unchanged)
tests-library/WorkspaceHandlingTests.ts 20ms (unchanged)
tsconfig.json 1ms (unchanged)
utils/BrowserTabsUtil.ts 13ms (unchanged)
utils/CheReporter.ts 34ms (unchanged)
utils/DevfilesHelper.ts 30ms (unchanged)
utils/DevWorkspaceConfigurationHelper.ts 17ms (unchanged)
utils/DriverHelper.ts 99ms (unchanged)
utils/IContextParams.ts 5ms (unchanged)
utils/IKubernetesCommandLineToolsExecutor.ts 4ms (unchanged)
utils/KubernetesCommandLineToolsExecutor.ts 50ms (unchanged)
utils/Logger.ts 18ms (unchanged)
utils/request-handlers/CheApiRequestHandler.ts 11ms (unchanged)
utils/request-handlers/headers/CheMultiuserAuthorizationHeaderHandler.ts 7ms (unchanged)
utils/request-handlers/headers/IAuthorizationHeaderHandler.ts 2ms (unchanged)
utils/ScreenCatcher.ts 11ms (unchanged)
utils/ShellExecutor.ts 5ms (unchanged)
utils/StringUtil.ts 7ms (unchanged)
utils/workspace/ApiUrlResolver.ts 5ms (unchanged)
utils/workspace/ITestWorkspaceUtil.ts 4ms (unchanged)
utils/workspace/TestWorkspaceUtil.ts 30ms (unchanged)
utils/workspace/WorkspaceStatus.ts 1ms (unchanged)

[ashmaraiev@fedora e2e]$ npm run lint

> @eclipse-che/che-e2e@7.104.0-next lint
> eslint --fix .

[ashmaraiev@fedora e2e]$

What issues does this PR fix or reference?

How to test this PR?

Run AnsibleDevFileAPI as ususally
Trial launch on Jenkins using specific branch:
https://jenkins-csb-crwqe-main.dno.corp.redhat.com/job/Testing/job/e2e/job/basic/job/api-tests/13150/console

PR Checklist

Trial launch on Jenkins using pecific branch:
https://jenkins-csb-crwqe-main.dno.corp.redhat.com/job/Testing/job/e2e/job/basic/job/api-tests/13150/console
As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

tests/e2e/utils/KubernetesCommandLineToolsExecutor.ts

dmytro-ndp · 2025-06-10T15:51:05Z

I would also propose to verify the removal of the test pod after the workspace removal:

 events:
   preStop:
     - "molecule-destroy"

tests/e2e/specs/api/AnsibleDevFileAPI.spec.ts

tests/e2e/utils/KubernetesCommandLineToolsExecutor.ts

artaleks9 · 2025-06-11T13:52:37Z

Fixed according to review notes.
Trial launch on Jenkins:
https://jenkins-csb-crwqe-main.dno.corp.redhat.com/job/Testing/job/e2e/job/basic/job/api-tests/13188/consoleFull

dmytro-ndp · 2025-06-11T19:23:07Z

tests/e2e/utils/KubernetesCommandLineToolsExecutor.ts

+	 * checks Molecule pod is removed after deleting asnsible-demo sample workspace
+	 * @throws Error if Molecule pod is not removed within the timeout
+	 */
+	waitRemovingMoleculePod(): void {


This method appears to be specific to the AnsibleDevFileAPI test, whereas the KubernetesCommandLineToolsExecutor class serves as a utility for common methods.

For the sake of consistency, I recommend either moving the waitRemovingMoleculePod() method to the AnsibleDevFileAPI test, or modifying this method to accept a pod name parameter waitRemovingPod(podName: string) and then calling it from AnsibleDevFileAPI.

It seems yes, need to fix up it.
Will do.

dmytro-ndp

Good job, @artaleks9

PR looks good to merge, with a non-critical notice.

tests/e2e/utils/KubernetesCommandLineToolsExecutor.ts

artaleks9 added 3 commits June 6, 2025 18:01

Add mmethods to pageobject

74b13d6

Add 'AnsibleDevFileAP' E2E test

f0b6e28

Fix up

639ed17

artaleks9 requested a review from SkorikSergey June 10, 2025 08:48

artaleks9 self-assigned this Jun 10, 2025

artaleks9 requested review from dmytro-ndp and musienko-maxim as code owners June 10, 2025 08:48

artaleks9 removed the request for review from musienko-maxim June 10, 2025 08:49

github-advanced-security bot found potential problems Jun 10, 2025

View reviewed changes

tests/e2e/utils/KubernetesCommandLineToolsExecutor.ts Fixed Show fixed Hide fixed

tests/e2e/utils/KubernetesCommandLineToolsExecutor.ts Dismissed Show dismissed Hide dismissed

SkorikSergey approved these changes Jun 10, 2025

View reviewed changes

dmytro-ndp reviewed Jun 10, 2025

View reviewed changes

tests/e2e/utils/KubernetesCommandLineToolsExecutor.ts Outdated Show resolved Hide resolved

dmytro-ndp reviewed Jun 10, 2025

View reviewed changes

tests/e2e/specs/api/AnsibleDevFileAPI.spec.ts Outdated Show resolved Hide resolved

artaleks9 added 2 commits June 11, 2025 15:23

Merge branch 'main' of github.com:eclipse/che into crw-7997

8790aff

Add changes accordig to review

fddeacb

github-advanced-security bot found potential problems Jun 11, 2025

View reviewed changes

tests/e2e/utils/KubernetesCommandLineToolsExecutor.ts Dismissed Show dismissed Hide dismissed

Increase timeout to reliability

ec65529

dmytro-ndp reviewed Jun 11, 2025

View reviewed changes

dmytro-ndp approved these changes Jun 11, 2025

View reviewed changes

Change method according to the review

2ecc167

github-advanced-security bot found potential problems Jun 12, 2025

View reviewed changes

tests/e2e/utils/KubernetesCommandLineToolsExecutor.ts Dismissed Show dismissed Hide dismissed

artaleks9 merged commit 1999bed into main Jun 12, 2025
6 checks passed

artaleks9 deleted the crw-7997 branch June 12, 2025 11:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Add 'AnsibleDevFileAPI' E2E test#23456

Add 'AnsibleDevFileAPI' E2E test#23456
artaleks9 merged 7 commits intomainfrom
crw-7997

artaleks9 commented Jun 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dmytro-ndp commented Jun 10, 2025

Uh oh!

Uh oh!

Uh oh!

artaleks9 commented Jun 11, 2025

Uh oh!

dmytro-ndp Jun 11, 2025 •

edited

Loading

Uh oh!

artaleks9 Jun 11, 2025

Uh oh!

dmytro-ndp left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

artaleks9 commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dmytro-ndp commented Jun 10, 2025

Uh oh!

Uh oh!

Uh oh!

artaleks9 commented Jun 11, 2025

Uh oh!

dmytro-ndp Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

artaleks9 Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

artaleks9 commented Jun 10, 2025 •

edited

Loading

dmytro-ndp Jun 11, 2025 •

edited

Loading