[Test] Support SSH keys from environment variables in SshUrlNoOauthPatFactory E2E test #23634
+51
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkorikSergey
added
the
status/code-review
artaleks9
approved these changes
Oct 28, 2025
dmytro-ndp
reviewed
Oct 28, 2025
| await userPreferences.addSshKeysFromStrings(privateSshKey, publicSshKey); | ||
| } else { | ||
| Logger.info('Using SSH keys from file paths'); | ||
| await userPreferences.addSshKeys(privateSshKeyPath, publicSshKeyPath); |
Contributor
There was a problem hiding this comment.
I would suggest renaming userPreferences.addSshKeys() to userPreferences.uploadSshKeys() to make the difference with userPreferences.addSshKeysFromStrings() obvious.
Contributor
Author
There was a problem hiding this comment.
userPreferences already has uploadSshKeys() that used in addSshKeys()
Contributor
Author
There was a problem hiding this comment.
What do you think about addSshKeysFromFiles()?
Contributor
There was a problem hiding this comment.
addSshKeysFromFiles() sounds good as well to me
Thank you!
dmytro-ndp
approved these changes
Oct 28, 2025
Contributor
dmytro-ndp
left a comment
dmytro-ndp
left a comment
There was a problem hiding this comment.
Looks good to merge, with a minor non-critical notice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support SSH keys from environment variables in SshUrlNoOauthPatFactory E2E test:
addSshKeysFromStrings()method toUserPreferencespage object for direct SSH key string inputTS_SELENIUM_SSH_PRIVATE_KEYandTS_SELENIUM_SSH_PUBLIC_KEYconstants toFACTORY_TEST_CONSTANTSSshUrlNoOauthPatFactorytest to support dual-mode SSH key loading:Screenshot/screencast of this PR
What issues does this PR fix or reference?
This PR is part of https://issues.redhat.com/browse/CRW-5392
How to test this PR?
To test with environment variables set
TS_SELENIUM_SSH_PRIVATE_KEYandTS_SELENIUM_SSH_PUBLIC_KEYTo test with file paths set
TS_SELENIUM_SSH_PRIVATE_KEY_PATHandTS_SELENIUM_SSH_PUBLIC_KEY_PATHPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.