NoSetupRepoFactory e2e test should work correctly with GitHub repositories#23710
Closed
SkorikSergey wants to merge 1 commit intomainfrom
Closed
NoSetupRepoFactory e2e test should work correctly with GitHub repositories#23710SkorikSergey wants to merge 1 commit intomainfrom
SkorikSergey wants to merge 1 commit intomainfrom
Conversation
SkorikSergey
added
the
status/code-review
SkorikSergey
requested review from
dmytro-ndp and
musienko-maxim
as code owners
SkorikSergey
changed the title
SkorikSergey
added
status/in-progress
Contributor
Author
|
Will be done by other PR -> #23711. |
SkorikSergey
removed
the
status/in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
NoSetupRepoFactory e2e test should work correctly with GitHub repositories
As this test starts on DevSpaces without OAuth or PAT it not possible to push any changes. This behavior checking should be added.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-9743
How to test this PR?
The NoSetupRepoFactory test should pass successfully with any public GitHub repository URL provided via TS_SELENIUM_FACTORY_GIT_REPO_URL.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.