Avoid generic parameters in Chromatogram(Selection)#2068
Merged
eselmeister merged 1 commit intoeclipse-chemclipse:developfrom Feb 17, 2025
Merged
Avoid generic parameters in Chromatogram(Selection)#2068eselmeister merged 1 commit intoeclipse-chemclipse:developfrom
eselmeister merged 1 commit intoeclipse-chemclipse:developfrom
Conversation
Mailaender
force-pushed
the
ungeneric-chromatogram
branch
from
75b166a to
be62ee3
Compare
Mailaender
force-pushed
the
ungeneric-chromatogram
branch
2 times, most recently
from
61d6c59 to
4f8f455
Compare
Mailaender
force-pushed
the
ungeneric-chromatogram
branch
3 times, most recently
from
c6e6ac9 to
e343eac
Compare
Mailaender
force-pushed
the
ungeneric-chromatogram
branch
from
e343eac to
77589be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a gigantic API change with the aim of removing generic parameters from commonly used API which introduces numerous wildcard characters that should be avoided especially in method returns, and it causes many warnings because type checks fail. I see that the root cause is the way that Java generics are limited by not allowing implementing generic interfaces again, making lists with bound generic types read-only etc.
But it is also conceptually wrong to define a chromatogram by its peak (and which only differ slightly by peak model MSD) and not its scans, which are defining content. Doing both would probably create even harder to read/maintain code, so I try to put the generic types into lists instead and override the interfaces. This is still using generics but defined by inheritance, which is nearer to the legacy code.