Split PCR UI into separate plugin#2069
Merged
eselmeister merged 1 commit intoeclipse-chemclipse:developfrom Feb 3, 2025
Merged
Split PCR UI into separate plugin#2069eselmeister merged 1 commit intoeclipse-chemclipse:developfrom
eselmeister merged 1 commit intoeclipse-chemclipse:developfrom
Conversation
Mailaender
added a commit
to OpenChrom/openchrom
that referenced
this pull request
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having one monolithic UI bundle proved pretty much unmaintainable. The PCR feature is large and distinct enough to warrant its own plug-in. It is a large diff, but it separates quite cleanly with no need to duplicate anything.
The only user visible change is that the PCR Data Explorer can only open PCR files from now on because no other file type makes sense here.