Skip to content

Reduce static access methods in AbstractActivatorUI #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eselmeister merged 1 commit into from
Feb 26, 2026
+6 −28
Merged

Reduce static access methods in AbstractActivatorUI #2742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions ...e.rcp.app.ui/src/org/eclipse/chemclipse/rcp/app/ui/handlers/PerspectiveSwitchHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* which is available at https://www.eclipse.org/legal/epl-2.0/
*
* SPDX-License-Identifier: EPL-2.0
*
*
* Contributors:
* Philip Wenig - initial API and implementation
*******************************************************************************/
Expand All @@ -15,7 +15,6 @@
import java.util.ArrayList;
import java.util.List;

import org.eclipse.chemclipse.rcp.app.ui.Activator;
import org.eclipse.chemclipse.rcp.app.ui.dialogs.PerspectiveChooserDialog;
import org.eclipse.chemclipse.rcp.app.ui.dialogs.PerspectiveSwitcherDialog;
import org.eclipse.chemclipse.rcp.app.ui.preferences.PreferenceSupplier;
Expand Down Expand Up @@ -97,12 +96,6 @@ public static void focusPerspectiveAndView(String perspectiveId, List<String> vi
}
}

public static boolean isActivePerspective(String perspectiveId) {

String activePerspective = Activator.getDefault().getActivePerspective();
return activePerspective.equals(perspectiveId);
}

/*
* Show a dialog if requested. The boolean values: P_SHOW_PERSPECTIVE_DIALOG
* P_CHANGE_PERSPECTIVE_AUTOMATICALLY can be edited by the user.
Expand Down
25 changes: 5 additions & 20 deletions ...lipse.support.ui/src/org/eclipse/chemclipse/support/ui/activator/AbstractActivatorUI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* which is available at https://www.eclipse.org/legal/epl-2.0/
*
* SPDX-License-Identifier: EPL-2.0
*
*
* Contributors:
* Philip Wenig - initial API and implementation
*******************************************************************************/
Expand Down Expand Up @@ -71,7 +71,7 @@ public IPreferenceStore getPreferenceStore() {
* Returns the image given by the key.
* Please initialize the image registry before using this function.
* Use the method e.g.:
*
*
* getImage(ICON_WARN)
*/
public Image getImage(String key) {
Expand Down Expand Up @@ -99,11 +99,6 @@ public EPartService getPartService() {
return getEclipseContext().get(EPartService.class);
}

public PartSupport getPartSupport() {

return getEclipseContext().get(PartSupport.class);
}

public PerspectiveSupport getPerspectiveSupport() {

return getEclipseContext().get(PerspectiveSupport.class);
Expand Down Expand Up @@ -168,16 +163,6 @@ public IEclipseContext getEclipseContext() {
return eclipseContext;
}

public boolean saveDirtyParts() {

return getPartSupport().saveDirtyParts();
}

public String getActivePerspective() {

return getPerspectiveSupport().getActivePerspective();
}

/**
* Initialize the preference store.
*/
Expand All @@ -198,14 +183,14 @@ protected void initializePreferenceStore(IPreferenceSupplier preferenceSupplier)
/**
* Initialize the image registry.
* Please supply a HashMap of used images/icons, e.g.:
*
*
* <pre><code>
* public static final String ICON_WARN = "ICON_WARN";
*
*
* Map&lt;String, String&gt; imageHashMap = new HashMap&lt;&gt;();
* imageHashMap.put(ICON_WARN, "icons/16x16/warn.gif");
* </code></pre>
*
*
* The icon path is set relative to the calling plugin.
*/
protected void initializeImageRegistry(Map<String, String> imageHashMap) {
Expand Down