Minor optimizations#2753
Merged
eselmeister merged 5 commits intoeclipse-chemclipse:developfrom Feb 27, 2026
Merged
Conversation
Creating a Point to call SWT method that accepts x,y params too and override it immediately with the Point returned by SWT just slows down the code and makes it harder to read.
As the perspectiveId is what is looked for let EModelService.findElements actually do the filtering and iterate over fewer elements after that.
* Add missing @OverRide * Remove useless non-javadoc and useless javadoc tags * Use Comparator.comparing for clarity * Stop needlessly passing null to findElements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.