Simplify live patch generation handling#596
Draft
AlexanderLanin wants to merge 1 commit intoeclipse-csi:mainfrom
Draft
Simplify live patch generation handling#596AlexanderLanin wants to merge 1 commit intoeclipse-csi:mainfrom
AlexanderLanin wants to merge 1 commit intoeclipse-csi:mainfrom
Conversation
…f having a special handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the
generate_live_patchfunction to return the generated patch directly instead of using a handler. This change streamlines the process and improves code clarity.This is like 90% working. Is it going in a reasonable direction? At least for me it's easier and more understandable when functions return the result, instead of using out-parameters. Especially complex ones like handlers.
This is slower as there is no partial handler call as before, not sure if that matters anywhere though.