Skip to content

Refactor pull request handling#605

Draft
AlexanderLanin wants to merge 7 commits intoeclipse-csi:mainfrom
AlexanderLanin:provider_pr
Draft

Refactor pull request handling#605
AlexanderLanin wants to merge 7 commits intoeclipse-csi:mainfrom
AlexanderLanin:provider_pr

Conversation

@AlexanderLanin
Copy link
Contributor

This pulls the PullRequest class one level up, so it can use the GraphQL API as well. New features that would benefit from this are not included in this PR. (The code is already there in different places, it's just not in the PullRequest class)

In order to achieve that, users like InstallationBasedTask must not use rest_api and graphql_api directly. They must use GitHubProvider abstraction level.

Hint: see individual commits for review. Unfurtunately quite a lot of code needed to be touched here.

⚠️ I was not able to test the webapp functionality. Ideally this is just refactoring, and absolutely no behavior change, But the last commit is a good example of stuff that mypy did not catch :(

Resolves #604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

architecture: InstallationBasedTask reaches into GitHub details

1 participant