Refactor pull request handling#605
Draft
AlexanderLanin wants to merge 7 commits intoeclipse-csi:mainfrom
Draft
Conversation
…rom pull_request_client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls the
PullRequestclass one level up, so it can use the GraphQL API as well. New features that would benefit from this are not included in this PR. (The code is already there in different places, it's just not in thePullRequestclass)In order to achieve that, users like
InstallationBasedTaskmust not userest_apiandgraphql_apidirectly. They must useGitHubProviderabstraction level.Hint: see individual commits for review. Unfurtunately quite a lot of code needed to be touched here.
Resolves #604