feat: restrict the logical constraints domain #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliapampus
approved these changes
Mar 27, 2025
Contributor
|
@jimmarino could you please check? |
jimmarino
approved these changes
Mar 27, 2025
juliapampus
merged commit c8ff8c2
into
eclipse-dataspace-protocol-base:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Currently, a logical constraint may contain anything. This PR restricts that to an array of the Constaint class.
Why it does that
type-safety
Further notes
added a test.
Linked Issue(s)
Closes #93
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.