feat: make DataAddress.endpoint property optional
#176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmarino
requested review from
arnoweiss,
juliapampus,
mkollenstart and
ssteinbuss
jimmarino
changed the title
DataAddress.endpoint property optionalDataAddress.endpoint property optional
arnoweiss
approved these changes
Jun 11, 2025
Contributor
arnoweiss
left a comment
arnoweiss
left a comment
There was a problem hiding this comment.
Makes sense. It should be encouraged to still use endpoint in the best practices.
ssteinbuss
approved these changes
Jun 12, 2025
ssteinbuss
merged commit 83a2d85
into
eclipse-dataspace-protocol-base:main
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Makes the
DataAddress.endpointproperty optional.Linked Issue(s)
Closes #156
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.