Remove Data ID / SetId functionality #2395
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| size_t CSHMReaderLayer::OnNewShmFileContent(const Payload::TopicInfo& topic_info_, const char* buf_, size_t len_, long long id_, long long clock_, long long time_, size_t hash_) | ||
| size_t CSHMReaderLayer::OnNewShmFileContent(const Payload::TopicInfo& topic_info_, const char* buf_, size_t len_, long long clock_, long long time_, size_t hash_) |
Contributor
There was a problem hiding this comment.
warning: method 'OnNewShmFileContent' can be made static [readability-convert-member-functions-to-static]
ecal/core/src/readwrite/shm/ecal_reader_shm.h:52:
- size_t OnNewShmFileContent(const Payload::TopicInfo& topic_info_, const char* buf_, size_t len_, long long clock_, long long time_, size_t hash_);
+ static size_t OnNewShmFileContent(const Payload::TopicInfo& topic_info_, const char* buf_, size_t len_, long long clock_, long long time_, size_t hash_);| // send content via data writer layer | ||
| const long long write_time = (time_ == DEFAULT_TIME_ARGUMENT) ? eCAL::Time::GetMicroSeconds() : time_; | ||
| const size_t written_bytes = m_publisher_impl->Write(payload_, write_time, m_filter_id); | ||
| const size_t written_bytes = m_publisher_impl->Write(payload_, write_time); |
Contributor
There was a problem hiding this comment.
warning: implicit conversion 'bool' -> 'const size_t' (aka 'const unsigned long') [readability-implicit-bool-conversion]
Suggested change
| const size_t written_bytes = m_publisher_impl->Write(payload_, write_time); | |
| const size_t written_bytes = static_cast<const size_t>(m_publisher_impl->Write(payload_, write_time)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In eCAL 5, publishers and subscribers could assign Data IDs via SetId(). This allowed users to optimize data flow by routing or discarding messages based on those IDs.
In eCAL 6, the API no longer supports this mechanism. Filtering can instead be implemented directly in subscriber callbacks, and topic names provide a clearer, more consistent way to differentiate data.
Keeping the Data ID code paths around only added complexity:
This PR removes all internal functionality related to Data IDs, simplifying the codebase and aligning with the eCAL 6 design. It doesn't remove the old API however.
What’s changed