modify initialState with EditorState types in GlobalState.tsx file#203
Draft
Rohithgvmg wants to merge 2 commits intoeclipse-editdor:masterfrom
Draft
modify initialState with EditorState types in GlobalState.tsx file#203Rohithgvmg wants to merge 2 commits intoeclipse-editdor:masterfrom
Rohithgvmg wants to merge 2 commits intoeclipse-editdor:masterfrom
Conversation
✅ Deploy Preview for editdor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
after these changes, the code is squiggle free |
Contributor
|
Good work @Rohithgvmg. Thanks for your effort |
Contributor
|
The implementation of the json indentation on the Settings section is not in the master. Good initial work however there is typescript errors. You need to update the typescript types defined and as well the reducer. With those you can dispatch an event on Settings section. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #202