[master] Bugfix for Native Query: "?" in SQL comments is treated as bindable query parameter #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 25, 2020 11:41
Signed-off-by: Radek Felcman <[email protected]>
Signed-off-by: Radek Felcman <[email protected]>
lukasj
reviewed
Jun 25, 2020
| * @return Query string without line comments. | ||
| */ | ||
| private String removeLineComments(String queryString) { | ||
| StringTokenizer multiLineTokenizer = new StringTokenizer(queryString, "\n"); |
Member
There was a problem hiding this comment.
will this work for windows line endings (\r\n) as well?
Contributor
Author
There was a problem hiding this comment.
I think, that it is tested at NamedNativeQueryJUnitTest.java line 175
Signed-off-by: Radek Felcman <[email protected]>
jnehlmeier
reviewed
Jul 23, 2020
|
|
||
| while (multiLineTokenizer.hasMoreTokens()) { | ||
| String s = multiLineTokenizer.nextToken(); | ||
| if (!"--".equals(s.trim().substring(0,2))) |
There was a problem hiding this comment.
What about comments at the end of the line?
insert into table_name (col1, col2)
values
(1,2), -- a comment is also possible here, right?
(3,4);There was a problem hiding this comment.
Also -- can be part of a string, e.g.
-- valid comment ? (1)
insert into table_name (textCol)
values -- valid comment ? (2)
('test test -- no comment ?
-- no comment ? test test
test test');Above code would remove comment (1), not detect comment (2) and accidentally remove the second "no comment" line inside a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix + unit test for a bug #822 .