-
Notifications
You must be signed in to change notification settings - Fork 165
Add Core Profile 11 Runner for Glassfish Embedded Web #25446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Having this file in the Uber jar was marking it as a bean archive and causing conflicts with the CDI Extensions adding the beans programatically
|
Hi, @Thihup, this PR now passes the usual Jenkins CI. That doesn't run the Core TCK though. What's the status? Does this runner run all the Core Profile TCKs? Do all tests pass? |
|
We have two Java files changes about a report, and the rest of the files is the usual copy of the ones in the platform-tck. We may think about whether we want to continuously copy these files, or just let them be at the platform-tck? |
This comment was marked as resolved.
This comment was marked as resolved.
|
It looks like this is just a work in progress and currently runs GlassFish Server and not Embedded. Turned it into a draft. |
|
It would be a great bennefit to have GlassFish Server run the core TCK as well. Maybe we can split this in 2 issues? One for Server and one for Embedded? Additionally there is the matter of copying all runners from https://github.com/jakartaee/platform-tck/tree/main/glassfish-runner or just leaving them there. |
No description provided.